From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.help Subject: Re: Help making a map-do/seq-do based code work on emacs 26.3 Date: Thu, 5 May 2022 12:24:12 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="317"; mail-complaints-to="usenet@ciao.gmane.io" To: Help Gnu Emacs mailing list , Nicolas Petton , Stefan Monnier Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 18:43:09 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmeZJ-000AVs-Jr for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 18:43:09 +0200 Original-Received: from localhost ([::1]:41934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmeZI-0005aJ-5t for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 12:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeHe-0000E6-83 for help-gnu-emacs@gnu.org; Thu, 05 May 2022 12:24:54 -0400 Original-Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:42643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmeHc-0007Md-43 for help-gnu-emacs@gnu.org; Thu, 05 May 2022 12:24:53 -0400 Original-Received: by mail-pj1-x1036.google.com with SMTP id l11-20020a17090a49cb00b001d923a9ca99so4554217pjm.1 for ; Thu, 05 May 2022 09:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=m3kMkATTxqE9O8kJE8M2BJGMk1XmjLB7BDJLM+1YYoI=; b=Wxt5IurpWbDf3L2QzcBg3VyTJ6eX3S8mJ6OQvIycPaaGYfIEfXu+tXgFk3BZWYvQ8g 9crf0kyGRiiEIGsXb8RcW/+8pKu3Ntof57O5X1fioFtz9i1l7cWtwwaJvAkhG2sI5nd2 pRuGFMYAd2+J0C/JHHq1EPCKdsaRRQjhq7W9cCq5HdjUHIq9lGvmdrpmIQAycmYxcQwZ KUYIWKMf65hhobD6t6NyvnAl3yJD3A7JVVQdUsn96HlbJZOCnabfAI7ftfSq8sYB6rdb wtCc/8jcS2CTgLAjixsUDHoYL65gi7nMCP17gFYTfERI7Y/9ctB9XichML+5ep1IXN78 vSuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=m3kMkATTxqE9O8kJE8M2BJGMk1XmjLB7BDJLM+1YYoI=; b=x7MP7e8bASdtTyOvTrfZv5zDiRuQSlWUwCGMmPIvVHkVfmpODSIxAuyidWVt47ZcYt IdA2+McNC4SL6obHyV5OyooaQMBtcduXUhu5RpYyH8eLxoAqKiyfrIN9gVIctBvLI2G8 lUAOY2IuovmaU71PbD4xDovsTo+m3+5ZGAcywS/dAlnky/8Uj/JsHQpIOVFcGFfm2W5n u0UIfpXEYFuEbBym8spGaPiTlQX0PancAVm6rB6xcQMQ+LwgUrEYhT/caikOfh6nUakR hRZ0g7nmceBGzKmF8MmJFUfV8ekEMJhDDfUoCwrty41tdiqfma5aXqqCygAU3j3vPQxC QTPA== X-Gm-Message-State: AOAM533K3EcNCDRQ6GlRu7EQ+pKTawNrE5h6q7q/qkCsdze3ZgnB00HM 8VmL3CaCjNvXeFwFnpXaPwaYqa1lLeC5YaUBGRBpjSqbV50= X-Google-Smtp-Source: ABdhPJxZiNaLcGeR+h3sgHxJU5hXc6e2XxroJNAAIv5qgacreRgv4Nzfs3dH1c/E0MN/PSS0VUkNQWE/HSDW8uPslXk= X-Received: by 2002:a17:90b:3e84:b0:1dc:5942:af0e with SMTP id rj4-20020a17090b3e8400b001dc5942af0emr7118695pjb.61.1651767888764; Thu, 05 May 2022 09:24:48 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=kaushal.modi@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:137148 Archived-At: Hi Stefan, Thanks for your reply. (I realized that I had got auto-unsubscribed from this mailing list! But I later found your reply online at https://lists.gnu.org/r/help-gnu-emacs/2022-05/msg00027.html I have now re-subscribed.). > For `seq`, yes, but `map` is not in GNU ELPA. map is actually available from GNU ELPA. I tried adding this to tomelr.el and it worked!! === ;; Package-Requires: ((emacs "26.3") (map "3.2.1") (seq "2.23")) === I couldn't do (package-install 'map) from an emacs 26.3 session. But running (package-install-file "tomelr.el") installed the newer map and seq from GNU ELPA. So I am hoping that when a user installs the new tomelr version from GNU ELPA (on Emacs 26.3), it will install the newer map and seq versions for them as well. I have now added this to the CI setup, which now seems to work for emacs 26.3 too: ===(defun tomelr-install () "Test installation of `tomelr' including all its dependencies." (let ((tomelr-site-git-root (progn (require 'vc-git) (file-truename (vc-git-root default-directory))))) (setq package-user-dir (let ((elpa-dir-name (format "elpa_%s" emacs-major-version))) ;default = "elpa" (file-name-as-directory (expand-file-name elpa-dir-name user-emacs-directory)))) ;; Below require will auto-create `package-user-dir' it doesn't exist. (require 'package) ;; Load emacs packages and activate them. ;; Don't delete this line. (package-initialize) ; ;; `package-initialize' call is required before any of the below ;; can happen. (message "Emacs is now refreshing its package database...") (package-refresh-contents) (package-install-file (expand-file-name "tomelr.el" tomelr-site-git-root)) ;; (message "package-user-dir: %S" package-user-dir) ;; (message "load-path: %S" load-path) )) (tomelr-install) === Finally passing the plist test on 26.3 too : https://github.com/kaushalmodi/tomelr/runs/6309842382?check_suite_focus=true :)