Patch request - menu modifications

Patch request - menu modifications

[David Masterson]

I'd like to request two simple changes to the basic Emacs menus:

1. Add dired-quit ('q') to the dired menus.  It would make it easier to
traverse a directory tree using just the mouse (click directory to
descend and click dired-quit to return up). To me, it is not obvious
which menu to put it in.

2. Add kill-this-buffer to the "Buffers" menu.  The funny thing is that
where-is reports it as "<menu-bar> <file> <kill-buffer>", but I don't
see it there.

"GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll
bars) of 2020-12-14"
-- 
David Masterson

Re: Patch request - menu modifications

[moasenwood--- via Users list for the GNU Emacs text editor]

David Masterson wrote:

> I'd like to request two simple changes to the basic Emacs
> menus:
>
> 1. Add dired-quit ('q') to the dired menus. It would make it
> easier to traverse a directory tree using just the mouse
> (click directory to descend and click dired-quit to return
> up). To me, it is not obvious which menu to put it in.

Interesting ... I don't even have "dired-quit", q meanwhile is
`quit-window', which isn't dired specific ... certainly it
doesn't help you "descend", it buries the buffer!

Maybe you look for `dired-up-directory'?

(Here, it depends how you visualize the file system hierarchy,
I think ./ is _downmost_, like the basic element [1], but some
people think it it is the top node in a tree-like
data structure.)

> 2. Add kill-this-buffer to the "Buffers" menu. The funny
> thing is that where-is reports it as "<menu-bar> <file>
> <kill-buffer>", but I don't see it there.

`C-x k' `kill-buffer' ... so the menu has its own functions, now?

kill-this-buffer:

  This command can be reliably invoked only from the menu bar,
  otherwise it could decide to silently do nothing.

"it could decide"? ??? Okay?

> "GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, X toolkit,
> Xaw3d scroll bars) of 2020-12-14"

I have

  GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+
  Version 3.24.5, cairo version 1.16.0) of 2020-10-23


[1] https://www.youtube.com/watch?v=jwY8FXOivko - okay, just
    remember it was a whole different culture in the 90s...
    well, evidently ;)

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: Patch request - menu modifications

[Stefan Monnier]

> 2. Add kill-this-buffer to the "Buffers" menu.  The funny thing is that
> where-is reports it as "<menu-bar> <file> <kill-buffer>", but I don't
> see it there.

It's called "Close" in the "File" menu.


        Stefan

Re: Patch request - menu modifications

[moasenwood--- via Users list for the GNU Emacs text editor]

Stefan Monnier wrote:

>> 2. Add kill-this-buffer to the "Buffers" menu. The funny
>> thing is that where-is reports it as "<menu-bar> <file>
>> <kill-buffer>", but I don't see it there.
>
> It's called "Close" in the "File" menu.

So it's true! You _do_ discover things by using the menus!

:P

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: Patch request - menu modifications

[David Masterson]

moasenwood--- via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org> writes:

> David Masterson wrote:
>
>> I'd like to request two simple changes to the basic Emacs
>> menus:
>>
>> 1. Add dired-quit ('q') to the dired menus. It would make it
>> easier to traverse a directory tree using just the mouse
>> (click directory to descend and click dired-quit to return
>> up). To me, it is not obvious which menu to put it in.
>
> Interesting ... I don't even have "dired-quit", q meanwhile is
> `quit-window', which isn't dired specific ... certainly it
> doesn't help you "descend", it buries the buffer!

You're right -- I got it wrong!  (Could've swore it was dired-quit...)

> Maybe you look for `dired-up-directory'?

Didn't know that one, but that might work.

> (Here, it depends how you visualize the file system hierarchy,
> I think ./ is _downmost_, like the basic element [1], but some
> people think it it is the top node in a tree-like
> data structure.)

My goal is to 'f' into a directory and 'q' to exit a directory using
only the menu.  That would make the menu complete for walking the
directory tree. (I'm considering changing <mouse-1> to dired-find-file)

>> 2. Add kill-this-buffer to the "Buffers" menu. The funny
>> thing is that where-is reports it as "<menu-bar> <file>
>> <kill-buffer>", but I don't see it there.
>
> `C-x k' `kill-buffer' ... so the menu has its own functions, now?
>
> kill-this-buffer:
>
>   This command can be reliably invoked only from the menu bar,
>   otherwise it could decide to silently do nothing.
>
> "it could decide"? ??? Okay?

kill-this-buffer seems better so it doesn't take input. This could be
used to clean up buffers from walking the dir tree.

-- 
David Masterson

Re: Patch request - menu modifications

[David Masterson]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> 2. Add kill-this-buffer to the "Buffers" menu.  The funny thing is that
>> where-is reports it as "<menu-bar> <file> <kill-buffer>", but I don't
>> see it there.
>
> It's called "Close" in the "File" menu.

I have "Close Tab" not "Close" in the file menu -- two different things, no?

-- 
David Masterson

Re: Patch request - menu modifications

[Michael Heerdegen]

David Masterson <dsmasterson92630@outlook.com> writes:

> I have "Close Tab" not "Close" in the file menu [...]

Are you sure you don't have both?

Michael.

Re: Patch request - menu modifications

[David Masterson]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> David Masterson <dsmasterson92630@outlook.com> writes:
>
>> I have "Close Tab" not "Close" in the file menu [...]
>
> Are you sure you don't have both?

You're right -- how did I miss that?  However, I'm not working with tabs
(I'll have to try that), so "Close Tab" won't work on the only tab with
multiple buffer windows displayed, thus "Close This Buffer" is needed.

-- 
David Masterson

Re: Patch request - menu modifications

[Thibaut Verron]

2021-02-05 6:50 UTC+01:00, David Masterson <dsmasterson92630@outlook.com>:
> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
>> David Masterson <dsmasterson92630@outlook.com> writes:
>>
>>> I have "Close Tab" not "Close" in the file menu [...]
>>
>> Are you sure you don't have both?
>
> You're right -- how did I miss that?  However, I'm not working with tabs
> (I'll have to try that), so "Close Tab" won't work on the only tab with
> multiple buffer windows displayed, thus "Close This Buffer" is needed.
>

"Close this buffer" is exactly the "close" under "insert file", you
would get the same behaviour with C-x k RET.

Maybe what you mean instead is "remove this window", aka "delete-window" C-x 0?
That one seems to be missing from the menu indeed.

Re: Patch request - menu modifications

[David Masterson]

Thibaut Verron <thibaut.verron@gmail.com> writes:

> 2021-02-05 6:50 UTC+01:00, David Masterson <dsmasterson92630@outlook.com>:
>> Michael Heerdegen <michael_heerdegen@web.de> writes:
>>
>>> David Masterson <dsmasterson92630@outlook.com> writes:
>>>
>>>> I have "Close Tab" not "Close" in the file menu [...]
>>>
>>> Are you sure you don't have both?
>>
>> You're right -- how did I miss that?  However, I'm not working with tabs
>> (I'll have to try that), so "Close Tab" won't work on the only tab with
>> multiple buffer windows displayed, thus "Close This Buffer" is needed.
>>
>
> "Close this buffer" is exactly the "close" under "insert file", you
> would get the same behaviour with C-x k RET.

Geez!  I'm too much of an old-time keyboard user.  Right again!

> Maybe what you mean instead is "remove this window", aka "delete-window" C-x 0?
> That one seems to be missing from the menu indeed.

Nope.  "Close" was what I was thinking of.  Thanks.

-- 
David Masterson