From: Thierry Emery <see.sig@spamfoil.invalid>
Subject: Re: Emacs 21 and w3 on Debian
Date: Thu, 26 May 2005 12:11:03 +0200 [thread overview]
Message-ID: <87zmui8fgo.fsf@spamfoil.invalid> (raw)
In-Reply-To: 871x7vtdtq.fsf@spamfoil.invalid
I wrote:
> Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE> writes:
>
>> Wouldn't it be more correct to replace the first argument of
>> url-callback-arguments with the redirect-uri if there are any
>> such callback arguments present? I have experienced problems
>> with your solution that went away with this improvement.
>
> Through looking at the code, i thought that i had chosen the most
> cautious alternative, but it seems that i was wrong ...
Ok, i have taken a much better look at the different places in Debian
`sid' GNU Emacs 21.4 in which there are calls to `url-retrieve' and
found out that my bogus patch caused problems in
`w3-maybe-start-image-download' and
`w3-maybe-start-background-image-download',
but also in the Gnus library "nnweb.el".
I have submitted two patches for these problems to Debian:
- the first one replaces in "url-http.el" my erroneous:
(list redirect-uri)
with:
(cons redirect-uri
(and url-callback-arguments
(cdr url-callback-arguments)))
- the second patch adds in "nnweb.el" `url' as first argument
for `nnweb-callback' and as third argument in the call to
`nnweb-url-retrieve-asynch' in `nnweb-fetch-url' (arguments used
when calling `nnweb-callback' start with this third argument).
I have also submitted a modified patch to "url-http.el" as a follow-up
to my M-x report-emacs-bug.
The patch on "nnweb.el" is not applicable to CVS Emacs: library
"nnweb.el" does not call `url-retrieve' anymore, but uses
`mm-url-insert' instead, which calls `url-insert-file-contents'.
Finally, i have found that backporting to Emacs 21.4 the new
`url-retrieve-synchronously' from "url.el" in CVS Emacs avoids some
cases of Emacs 21.4 locking up (e.g. when a site has lots of images),
and have also submitted a patch for this to Debian.
Thanks again for pointing out my mistake,
Thierry
--
thierry |dot| emery |at| free |dot| fr
next prev parent reply other threads:[~2005-05-26 10:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-22 11:05 Emacs 21 and w3 on Debian Tim X
2005-05-22 20:14 ` Thierry Emery
2005-05-22 22:27 ` Tim X
2005-05-23 7:49 ` Tim X
[not found] ` <d6rt02$cho$1@news.sap-ag.de>
2005-05-23 7:53 ` Tim X
2005-05-23 9:09 ` Thierry Emery
[not found] ` <d6sa8f$mmu$1@news.sap-ag.de>
2005-05-23 17:22 ` Thierry Emery
2005-05-24 5:48 ` Klaus Straubinger
2005-05-24 16:39 ` Thierry Emery
2005-05-24 8:19 ` Tim X
[not found] ` <d71mbu$ka$1@news.sap-ag.de>
2005-05-25 17:28 ` Thierry Emery
2005-05-26 10:11 ` Thierry Emery [this message]
2005-05-27 6:15 ` Klaus Straubinger
2005-05-27 19:09 ` Thierry Emery
2005-05-30 6:33 ` Klaus Straubinger
2005-05-25 17:52 ` Kevin Rodgers
[not found] ` <mailman.1793.1117044330.25862.help-gnu-emacs@gnu.org>
2005-05-27 6:29 ` Klaus Straubinger
2005-05-27 16:35 ` Kevin Rodgers
[not found] ` <mailman.2099.1117212347.25862.help-gnu-emacs@gnu.org>
2005-05-30 6:26 ` Klaus Straubinger
2005-05-31 16:41 ` Kevin Rodgers
[not found] ` <mailman.2623.1117558050.25862.help-gnu-emacs@gnu.org>
2005-06-01 6:19 ` Klaus Straubinger
2005-06-01 15:57 ` Stefan Monnier
2005-06-02 6:42 ` Klaus Straubinger
2005-06-05 23:08 ` Stefan Monnier
2005-06-01 15:55 ` Stefan Monnier
[not found] ` <d6s5b2$itm$1@news.sap-ag.de>
2005-05-24 8:17 ` Tim X
2005-05-23 8:30 ` Thierry Emery
[not found] ` <d6s68c$jsf$1@news.sap-ag.de>
2005-05-23 9:57 ` Thierry Emery
[not found] ` <d6sble$nnv$1@news.sap-ag.de>
2005-05-23 17:25 ` Thierry Emery
2005-05-24 8:24 ` Tim X
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmui8fgo.fsf@spamfoil.invalid \
--to=see.sig@spamfoil.invalid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).