unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Uwe Brauer <oub@mat.ucm.es>
To: help-gnu-emacs@gnu.org
Subject: Re: calwf
Date: Wed, 13 Jan 2016 17:42:51 +0000	[thread overview]
Message-ID: <87ziw9nzok.fsf@mat.ucm.es> (raw)
In-Reply-To: jwva8oazxfb.fsf-monnier+gmane.emacs.help@gnu.org

>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

   > In both cases (calwf and weekly-view), I expect that the issue is a
   > simple question of renaming of a few functions/variables, or some
   > such.

Yes.
I had to introduce the following alias:

(defalias 'view-diary-entries 'diary-view-entries) ;which was even
obsolete in the diary-lib version of xemacs

But also 

(defalias 'general-holidays 'holiday-general-holidays)
(defalias 'oriental-holidays 'holiday oriental-holidays)
(defalias 'local-holidays 'holiday-local-holidays)
(defalias 'other-holidays  'holiday-other-holidays)
(defalias 'hebrew-holidays 'holiday-oriental-holidays)
(defalias 'christian-holidays 'holiday-christian-holidays)
(defalias 'islamic-holidays 'holiday-iclamic-holidays)

Because of the  the following ChangeLog entry

,----
| commit 3f65970414538063e38ada2a47cb4ef4f35b630e
| Author: Glenn Morris <rgm@gnu.org>
| Date:   Sun Oct 5 19:02:04 2014 -0700
| 
|     Remove calendar code obsolete since at least version 23.1
|     
| * lisp/calendar/holidays.el (general-holidays, oriental-holidays)
|     (local-holidays, other-holidays, hebrew-holidays)
`----

Frankly the rationale of renaming functions is beyond me, since it
breaks backwards compatibility.



   > Usually issues of compatibility between emacsen are fairly simple
   > to solve. E.g. the "nice display" in weekly-view in XEmacs might be
   > due simply to the fact that when the code was written it used
   > features not available in Emacs, so the author put a (featurep
   > 'xemacs) test in it. In that

He did not!


   > case, removing the test might actually be sufficient to get the
   > feature working, tho in most cases, this will bump into some
   > further compatibility issues.

   > IOW, these should all be fairly easy to debug by single-stepping
   > through the code and comparing where the execution diverges between
   > the two different emacsen.

Right. I will try that. My favorite debugging tool is edebug. Is there
anything better around now you could recommend?





  reply	other threads:[~2016-01-13 17:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 16:51 calwf Uwe Brauer
2016-01-12 14:29 ` calwf Stefan Monnier
2016-01-13 17:42   ` Uwe Brauer [this message]
2016-01-13 19:55     ` calwf tomas
2016-01-14 14:09     ` calwf Stefan Monnier
2016-01-14  8:54   ` calwf Uwe Brauer
2016-01-14 14:13     ` calwf Stefan Monnier
2016-01-14 17:00       ` calwf Uwe Brauer
2016-01-14 19:34         ` calwf Stefan Monnier
2016-01-15  9:05           ` [missing diary-display-hook] (was: calwf) Uwe Brauer
2016-01-15 13:56             ` [missing diary-display-hook] Stefan Monnier
2016-01-15 17:38               ` Uwe Brauer
2016-01-15 16:52             ` Glenn Morris
2016-01-15 17:42               ` Uwe Brauer
2016-01-15  9:06           ` calwf Uwe Brauer
2016-01-14 14:15     ` calwf Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ziw9nzok.fsf@mat.ucm.es \
    --to=oub@mat.ucm.es \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).