From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thorsten Jolitz Newsgroups: gmane.emacs.help Subject: Re: Suppress user-prompting when calling commands in programs Date: Fri, 13 Jun 2014 20:14:00 +0200 Message-ID: <87wqckisnr.fsf@gmail.com> References: <87r42skjd8.fsf@gmail.com> <877g4k7ux4.fsf@geodiff-mac3.ulb.ac.be> <878up0kfcv.fsf@gmail.com> <5b284aa3-068d-461d-a95b-52cd97ba292a@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402683288 3217 80.91.229.3 (13 Jun 2014 18:14:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Jun 2014 18:14:48 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Jun 13 20:14:41 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WvVzs-0000oW-0R for geh-help-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 20:14:40 +0200 Original-Received: from localhost ([::1]:60489 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvVzr-0004jh-CG for geh-help-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 14:14:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvVza-0004jS-Uf for help-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:14:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvVzV-0005tp-Al for help-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:14:22 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:36140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvVzV-0005tj-57 for help-gnu-emacs@gnu.org; Fri, 13 Jun 2014 14:14:17 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WvVzS-0000Sm-NA for help-gnu-emacs@gnu.org; Fri, 13 Jun 2014 20:14:14 +0200 Original-Received: from e178190046.adsl.alicedsl.de ([85.178.190.46]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Jun 2014 20:14:14 +0200 Original-Received: from tjolitz by e178190046.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Jun 2014 20:14:14 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 65 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: e178190046.adsl.alicedsl.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Cancel-Lock: sha1:EOkMH0IeEOiKttep+WEUqCLIhoE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:98219 Archived-At: Drew Adams writes: >> I tried convincing upstream before and never made it! > > Try again. hmmm ... >> And I actually understand the authors of code like that and even copied >> that technique sometimes, because it might be harder to write the >> interactive spec for both interactive and programmatical use than to >> write the function itself, and then there is no need for a wrapper >> command or interactive (lambda ...) expression when it comes to define >> a key for that command. > > Huh? Instead of: > > (defun foo (&optional arg) > (interactive "P") > (let ((bar (org-icompleting-read ...))) > ...)) > > What's wrong with them pushing the read into the interactive spec? > > (defun foo (&optional arg bar) > (interactive (list current-prefix-arg > (org-icompleting-read ...)))) > ...) probably nothing ... > That's the recommended approach, in general. > > Or if the (org-icompleting-read ...) code itself uses the prefix > arg as the variable ARG, then rename such occurrences of ARG to, > say, PREF), and bind PREF before invoking `org-icompleting-read': > > (defun foo (&optional arg bar) > (interactive > (let ((pref current-prefix-arg)) > (list pref (org-icompleting-read ...)))) > ...) > > Or if they really want to leave the beginning of the code the > same for some reason, they could at least factor out the body > (the second "..."), so you can invoke that code directly: > > (defun foo (&optional arg) > (interactive "P") > (let ((bar (org-icompleting-read ...))) > (foo-guts arg bar))) ; <== Just a wrapper for the body. > ; No other code changes needed. > > Then your code would just call `foo-guts'. yes, does not look too complicated ... >> But OTOH its a shame that many commands are hard/impossible to reuse in >> programs because of this 'trick'. > > A shame and unnecessary. -- cheers, Thorsten