From: Michael Heerdegen <michael_heerdegen@web.de>
To: Chunyang Xu <mail@xuchunyang.me>
Cc: help-gnu-emacs@gnu.org
Subject: Re: [el-search] How to search string excluding docstring?
Date: Mon, 25 Dec 2017 18:51:36 +0100 [thread overview]
Message-ID: <87wp1a3dcn.fsf@web.de> (raw)
In-Reply-To: <m2y3lqycbl.fsf@xuchunyang.me> (Chunyang Xu's message of "Tue, 26 Dec 2017 00:58:06 +0800")
Chunyang Xu <mail@xuchunyang.me> writes:
> I also realize another way, which is not general at all but seeming
> working. To check if the current string is docstring
>
> (save-excursion
> (backward-up-list)
> (pcase (read (current-buffer))
> (`(defun ,_ ,_ ,(and (pred stringp) docstring) . ,_)
> (string= docstring string))))
>
> then to search docstring
>
> (and (string) string (guard ...))
>
> It has a bug, for example, when search the following, it matches both
> the first and the second "foo" (the second is not wanted)
>
> (defun hello ()
> "foo"
> "foo"
> (message "foo"))
Yes, that's one of the pitfalls you can run into. One could try to find
out at which list position the current expression is - I've not really
needed something like this, however.
> So my current approach of searching string excluding docstring is
>
> (defun el-search--docstring-p (string)
> (save-excursion
> (backward-up-list)
> (pcase (read (current-buffer))
> (`(defun ,_ ,_ ,(and (pred stringp) docstring) . ,_)
> (string= docstring string)))))
>
> (and (string "foo") s (guard (not (el-search--docstring-p s))))
Yes, that should work fine (unless you have any top-level strings, but
that is never the case for code buffers). You could simplify it a bit
by using
(pred (string= string))
in the pattern.
Regards,
Michael.
next prev parent reply other threads:[~2017-12-25 17:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 10:27 [el-search] How to search string excluding docstring? Chunyang Xu
2017-12-25 10:40 ` Jean-Christophe Helary
2017-12-25 12:00 ` Skip Montanaro
2017-12-25 18:04 ` Michael Heerdegen
2017-12-25 14:56 ` Michael Heerdegen
2017-12-25 16:58 ` Chunyang Xu
2017-12-25 17:51 ` Michael Heerdegen [this message]
[not found] ` <mailman.6340.1514213787.27995.help-gnu-emacs@gnu.org>
2017-12-25 15:50 ` Emanuel Berg
2017-12-25 16:59 ` Michael Heerdegen
[not found] ` <mailman.6351.1514221174.27995.help-gnu-emacs@gnu.org>
2017-12-25 18:04 ` Emanuel Berg
[not found] <mailman.6328.1514197667.27995.help-gnu-emacs@gnu.org>
2017-12-25 12:00 ` Emanuel Berg
2017-12-25 13:57 ` Chunyang Xu
2017-12-25 14:34 ` Michael Heerdegen
[not found] ` <mailman.6334.1514210258.27995.help-gnu-emacs@gnu.org>
2017-12-25 14:08 ` Emanuel Berg
2017-12-25 17:55 ` tomas
[not found] ` <mailman.6358.1514224565.27995.help-gnu-emacs@gnu.org>
2017-12-25 18:11 ` Emanuel Berg
2017-12-25 19:14 ` tomas
[not found] ` <mailman.6366.1514229270.27995.help-gnu-emacs@gnu.org>
2017-12-25 19:36 ` Emanuel Berg
2017-12-25 21:20 ` tomas
[not found] ` <mailman.6371.1514236843.27995.help-gnu-emacs@gnu.org>
2017-12-25 21:56 ` Emanuel Berg
2017-12-26 2:44 ` Emanuel Berg
2017-12-26 13:34 ` Emanuel Berg
2017-12-26 13:48 ` Jean-Christophe Helary
[not found] ` <mailman.6381.1514296097.27995.help-gnu-emacs@gnu.org>
2017-12-26 15:19 ` Emanuel Berg
2017-12-27 5:38 ` Chunyang Xu
2017-12-27 13:58 ` Michael Heerdegen
[not found] ` <mailman.6406.1514353148.27995.help-gnu-emacs@gnu.org>
2017-12-27 6:58 ` Emanuel Berg
2017-12-25 19:39 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp1a3dcn.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=help-gnu-emacs@gnu.org \
--cc=mail@xuchunyang.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).