unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Alex <project@gnuhacker.org>
To: help-gnu-emacs@gnu.org
Subject: Re: EWW func add url under point as bookmark
Date: Mon, 18 Apr 2022 22:29:21 +0200	[thread overview]
Message-ID: <87wnfmqgny.fsf@gnu.org> (raw)
In-Reply-To: <87wnfooo8y.fsf@zoho.eu> (Emanuel Berg via Users list for the's message of "Sat, 16 Apr 2022 20:51:41 +0200")

Emanuel Berg via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org> writes:

> OK, good, but then better yet you could remove the interface/wrapper
> function and instead make eww-bookmark-add interactive (as well as
> non-interactive from Lisp), and for interactive use it'll read the URL
> from point.

new version:

#+begin_src elisp

;; Copyright 2022 Alex
;; under GPLv3-or-later License

(defun eww-bookmark-add (url title)
  "Bookmark `URL' as `TITLE'."
  (interactive (list (thing-at-point 'url)
		     (read-string "Title: ")))
  (unless (stringp url)
    (user-error "invalid url string required"))
  (unless (stringp title)
    (user-error "invalid title string required"))
  (eww-read-bookmarks)
  (dolist (bookmark eww-bookmarks)
    (when (equal url (plist-get bookmark :url))
      (user-error "Already bookmarked")))
  (push (list :url url
	      :title title
	      :time (current-time-string))
	eww-bookmarks)
  (eww-write-bookmarks)
  (message "Bookmarked %s (%s)" url title))

#+end_src

> Ironically then you have to get the title the way you initially did!

right lol

-- 
Alex
Emacs Lover.
FSF Member.
Free/Libre Software supporter.
stallmansupport.org - Disinformation succeeds because so many people
care deeply about injustice but do not take the time to check the facts.



  reply	other threads:[~2022-04-18 20:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 19:25 EWW func add url under point as bookmark Alex
2022-04-14 20:08 ` [External] : " Drew Adams
2022-04-14 23:31   ` Michael Heerdegen
2022-04-14 21:08 ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-15 13:40 ` Alex
2022-04-15 14:17   ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-16 14:34     ` Alex
2022-04-16 18:51       ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-18 20:29         ` Alex [this message]
2022-04-18 20:47           ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-18 22:13             ` Alex
2022-04-19  0:24               ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-16 19:12       ` Emanuel Berg via Users list for the GNU Emacs text editor
     [not found] ` <87ee1z8jap.fsf@zoho.eu>
     [not found]   ` <CAJcAo8v7+CYd03EyFi_oK+E8crS+9gLea0jBqziN9wPMvGvvrQ@mail.gmail.com>
2022-04-17  0:16     ` [emacs-w3m:13862] " Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnfmqgny.fsf@gnu.org \
    --to=project@gnuhacker.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).