From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: Re: Function to find symlink target Date: Thu, 19 May 2022 01:00:34 +0200 Message-ID: <87wneixx7x.fsf@dataswamp.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31904"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:YMdFNYqz7az3Y+oF6kAe32zcJhM= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 19 01:01:59 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrSg3-00082t-Q0 for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 19 May 2022 01:01:59 +0200 Original-Received: from localhost ([::1]:51170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrSg2-0001Po-2m for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 19:01:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrSes-0001PP-JT for help-gnu-emacs@gnu.org; Wed, 18 May 2022 19:00:46 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:60936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrSeq-0004bU-PD for help-gnu-emacs@gnu.org; Wed, 18 May 2022 19:00:46 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nrSeo-0006YI-I9 for help-gnu-emacs@gnu.org; Thu, 19 May 2022 01:00:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:137309 Archived-At: Jean Louis wrote: > (defun rcd-dired-find-symlink () > "Find target of a symlink" > (interactive) > (when (dired-get-marked-files) > (let ((file (car (dired-get-marked-files)))) > (if (file-symlink-p file) > (let* ((file (file-truename file)) > (directory (file-name-directory file)) > (file (file-name-nondirectory file)) > (back (length file))) > (find-file directory) > (search-forward file) > (backward-char back)) > (message "Not a symlink: %s" file))))) > > Let me know if I should improve this by any means. Hello again Jean! 1. Do auto-indentation ... 2. `require' is needed for `dired-get-marked-files', do byte-compile to find out and always do that before posting here. 3. The defun has a confusing name, you have already found the symlink one would think? 4. Emacs thinks of the docstring that the "[f]irst sentence should end with punctuation". Always do the style check before posting here BTW, here's an example how. [1] 5. `dired-get-marked-files' is invoked twice, instead just do it once and reuse the result with and in `let'. 6. "file" appears as a let-binding twice in `let*', confusing and probably no good reason to do so either, right? 7. I'm unsure but if you `find-file' a directory that is already open in a buffer, you still end up at `point-min'? If you don't, you need to got there before the search, (goto-char (point-min)) as you know. 8. Instead of doing `backward-char', do something like this: [you can try it below as well] (when (search-forward "key" (point-max) t) (goto-char (match-beginning 0)) ) key Wow, 8 paragraphs! That's what I call feedback ... [1] https://dataswamp.org/~incal/emacs-init/ide/pack-style.el -- underground experts united https://dataswamp.org/~incal