From: Felix Dietrich <felix.dietrich@sperrhaken.name>
To: help-gnu-emacs@gnu.org
Subject: Re: how to track down "invalid face attribute" errors?
Date: Thu, 06 Oct 2022 16:58:57 +0200 [thread overview]
Message-ID: <87wn9dxaku.fsf@sperrhaken.name> (raw)
In-Reply-To: <834jwitm3s.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Oct 2022 16:51:19 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Face merging has nothing to do with point, it just considers the face
> attributes. The commentary to merge_face_ref says how the window
> pointer is used:
Robert Pluim <rpluim@gmail.com> writes:
> Weʼre not necessarily examining the faces of the character at (point),
> weʼre going through redisplay of the buffer, I thought?
Uh, I blundered there in my examination and my thinking: when I ran
Emacs in a debugger with a breakpoint on “xfaces.c:merge_face_ref”, the
breakpoint was hit when I moved the cursor into or out of a position
with text that had an invalid property, and I made, from a position of
lacking understanding, a wrong assumption. Thanks to you two for
clearing that up.
> If you want to understand what that filtering is about, look at
> filter_face_ref, where you will clearly see that it never accesses the
> window's buffer or its point.
>
> So when this function is called, there's no reason to believe that the
> buffer position of point has anything to do with the offending face.
> The most frequent face merging is performed by redisplay, which
> doesn't move point and doesn't make the window on whose display it is
> working the selected window.
Thank you for the clarification.
>> Anyway, perhaps, if there is any interest in adding information to the
>> “Invalid face attribute” log message, further discussion should move to
>> a wishlist bug report?
>
> Definitely. This discussion doesn't belong to the help list.
The bug report can be found here:
bug#58312 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58312>
--
Felix Dietrich
next prev parent reply other threads:[~2022-10-06 14:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 12:03 how to track down "invalid face attribute" errors? Eric S Fraga
2022-09-25 13:00 ` Emanuel Berg
2022-09-26 9:04 ` Eric S Fraga
2022-09-26 9:40 ` Robert Pluim
2022-09-26 9:50 ` Fraga, Eric
2022-09-27 11:12 ` Felix Dietrich
2022-09-27 14:08 ` Robert Pluim
2022-10-05 12:32 ` Felix Dietrich
2022-10-05 13:31 ` Robert Pluim
2022-10-05 13:51 ` Eli Zaretskii
2022-10-06 14:58 ` Felix Dietrich [this message]
2022-09-28 11:41 ` Stefan Monnier via Users list for the GNU Emacs text editor
2022-09-28 15:04 ` Robert Pluim
2022-09-29 16:32 ` Emanuel Berg
2022-10-03 19:19 ` Felix Dietrich
2022-10-03 22:46 ` Emanuel Berg
2022-10-04 11:06 ` Felix Dietrich
2022-10-05 11:29 ` Felix Dietrich
2022-09-25 14:01 ` Eli Zaretskii
2022-09-25 15:53 ` Eric S Fraga
2022-09-25 16:06 ` Eli Zaretskii
2022-09-25 17:20 ` Eric S Fraga
2022-09-25 14:26 ` Felix Dietrich
2022-09-25 15:51 ` Fraga, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn9dxaku.fsf@sperrhaken.name \
--to=felix.dietrich@sperrhaken.name \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).