From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.help Subject: Re: package-autoremove ? Date: Fri, 25 Aug 2023 08:54:44 +0000 Message-ID: <87wmxjsdrf.fsf@posteo.net> References: <87cyzbtvv8.fsf@posteo.net> <87cyzbqzbm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1171"; mail-complaints-to="usenet@ciao.gmane.io" Cc: David Masterson , Rudolf Schlatte , help-gnu-emacs@gnu.org To: Tassilo Horn Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 25 10:55:28 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZSbI-000AdY-PO for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 25 Aug 2023 10:55:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZSai-00006z-Vd; Fri, 25 Aug 2023 04:54:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZSag-00006R-BM for help-gnu-emacs@gnu.org; Fri, 25 Aug 2023 04:54:50 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZSad-0004EC-Qw for help-gnu-emacs@gnu.org; Fri, 25 Aug 2023 04:54:50 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A2EF124002B for ; Fri, 25 Aug 2023 10:54:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692953685; bh=TKkiFUDbfVQkynKkuWvLNNJLpdWuowDZ4fNZdoLlY2E=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=AJYu5iYhfja+p2aM8cnQpZVmkFM+DYH0xztMO8wtJHrE7DKyYYk1C2FqQjqqk+mS8 B5u6plhwSgJJdhYrt83FjE6gkCLRy2U3/mGjFtKC4gsXqNXQAWWDlRDrYCbIOr3D2g zYhOIJxtg3AUEGeME1/GhjQQ/KiengL25Mbff62hmTzWvJDH/VDaO3aS42nLTcphhU Jlhx/caOuP9syhrA2P8wFJfna2nkmDBzwmGPD9pu72NdVSzVjNMDdvHyVevOHZp773 pLnESvAlTaiTlCQHpxrfmxLcV3wk2j7zghVXuHgseJiZjling2adh3Cyt3fEqh8MCJ BtiI6g84Of2Cg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RXDKd1zWQz6tyC; Fri, 25 Aug 2023 10:54:45 +0200 (CEST) In-Reply-To: <87cyzbqzbm.fsf@gnu.org> (Tassilo Horn's message of "Fri, 25 Aug 2023 10:40:34 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:144958 Archived-At: Tassilo Horn writes: }> Philip Kaludercic writes: > > Hi Philip, > >>>> For me, this situation comes up when I install a package via >>>> `(use-package ... :ensure t)' instead of via `list-packages'. >>> >>> Sounds like a good possibility for me as well. Someone should adjust >>> use-package to add the package to package-selected-packages for this >>> reason. My Lisp isn't that good. >> >> The :ensure keyword for use-package should select the packages, since >> it invokes `package-install' without setting the optional DONT-SELECT >> argument (use-package-ensure.el): >> >> --8<---------------cut here---------------start------------->8--- >> ... >> (if (assoc package package-archive-contents) >> (package-install package) >> (package-refresh-contents) >> (when (assoc package (bound-and-true-p >> package-pinned-packages)) >> (package-read-all-archive-contents)) >> (package-install package)) >> ... >> --8<---------------cut here---------------end--------------->8--- >> >> What might be an issue, is that package-install tries to save the >> modification of `package-selected-packages' to disk (package.el): >> >> --8<---------------cut here---------------start------------->8--- >> (if after-init-time >> (customize-save-variable 'package-selected-packages package-selected-packages) >> (add-hook 'after-init-hook #'package--save-selected-packages)) >> --8<---------------cut here---------------end--------------->8--- >> >> Now if you have customised `custom-file' and/or don't load the >> contents of the file, then upon restarting Emacs the updated value >> would be lost and package-autoremove would suggest removing all the >> packages installed by use-package (but also package-install, for that >> matter). > > Very good analysis. I'm also affected by that issue and indeed, I have > customized custom-file, because I use the very same user-init-file on > multiple machines but put minor machine-related tweaks in custom-file. > Basically, my user-init-file starts with: > > (setopt custom-file (expand-file-name > "custom.el" > (if user-init-file > (file-name-directory user-init-file) > "~/.emacs.d/"))) What is the point of this check? FWIW my init.el starts with (load (setq custom-file (locate-user-emacs-file "custom.el")) t) and I have never had issues with it. > (load custom-file t) > Now on two machines which should have pretty much the same emacs setup > (pretty current git master with the same init.el containing the same > use-package with :ensure t statements), package-autoremove suggests > different removal sets. The union of both sets contains many packages > installed by use-package which are certainly wrong. I have little to no experience with use-package, so I am not the best person to help here. Have you reported this behaviour as a bug? > It would be great if that could be fixed. > > Bye, > Tassilo