From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.help Subject: Re: package-vc-install bug? Date: Sat, 10 Feb 2024 15:41:43 +0000 Message-ID: <87wmrc498o.fsf@posteo.net> References: <87bk8qov9f.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: James Thomas Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 16:42:22 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYpUk-0004X0-Gj for geh-help-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 16:42:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYpUI-0007wg-Q1; Sat, 10 Feb 2024 10:41:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYpUG-0007n2-Q1 for help-gnu-emacs@gnu.org; Sat, 10 Feb 2024 10:41:52 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYpUD-0003PE-Jg for help-gnu-emacs@gnu.org; Sat, 10 Feb 2024 10:41:52 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 960DC240028 for ; Sat, 10 Feb 2024 16:41:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707579704; bh=mkGS+W2RkIS7JHQUFuvuO6IMZ8gI1CBgtbdryYSTmiM=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=I7sNPz+Lmpkf+csXK6usK8QikxApdJuAfPaFN6VkcxoDd5CcUYyNdEXnU/mQuSjcw ZXdmjULKZxerVxDf1nsAoS6qvzu0BKSnStXGvSX5enzId/QZr6Je6aVnCMmz+nS9bS 9KeHxByTnIunm8ZCu+5fd7k0Ur+fXCOQAmW6Xt0TJnupwOKWJ1FtycoFT2euhioSI2 p6sO28oo6pOxTBf6/ZDM3ckDkxHLugkA/dziknLRPcj3mvFzoP4RWiYm7IYIV5GYnY aAg9hRmhjacm9c6EYs5c5dZIrDR5LRlEwbRnncjOtwjFLrjGTS1W1RiyxAqq74lAJU zl8OqxuDyWcww== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TXFMD0qx0z6tyS; Sat, 10 Feb 2024 16:41:44 +0100 (CET) In-Reply-To: <87bk8qov9f.fsf@gmx.net> (James Thomas's message of "Fri, 09 Feb 2024 14:43:32 +0530") X-Hashcash: 1:20:240210:jimjoe@gmx.net::M8xzrOL1PLYNLgxZ:09C5 X-Hashcash: 1:20:240210:help-gnu-emacs@gnu.org::Q+wsWPtbVZ+EiAps:0XCr Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:145902 Archived-At: James Thomas writes: > M-x package-vc-install RET RET fails with the following on my > system: Does this issue occur for every package? > Debugger entered--Lisp error: (error "Can=E2=80=99t read whole string") > signal(error ("Can=E2=80=99t read whole string")) > error("Can't read whole string") > package-read-from-string("((emacs \"28.1\") (python \"0.2\") (csv-mode = \"1.12\"))") > package-vc--unpack-1(#s(package-desc :name python-view-data :version (2= 0230508 543) :summary "View data in python" :reqs ((emacs (28 1)) (python (= 0 2)) (csv-mode (1 12))) :kind vc :archive "melpa" :dir "/home/user/.emacs.= d/elpa/python-view-data/" :extras ((:commit . "1dd5f99679db9767530cfc20642a= 40a48bd479be") (:authors ("Shuguang Sun" . "shuguang79@qq.com")) (:maintain= ers ("Shuguang Sun" . "shuguang79@qq.com")) (:maintainer "Shuguang Sun" . "= shuguang79@qq.com") (:keywords "tools") (:url . "https://github.com/Shuguan= gSun/python-view-data")) :signed nil) "/home/user/.emacs.d/elpa/python-view= -data/") > package-vc--unpack(#s(package-desc :name python-view-data :version (202= 30508 543) :summary "View data in python" :reqs ((emacs (28 1)) (python (0 = 2)) (csv-mode (1 12))) :kind tar :archive "melpa" :dir nil :extras ((:commi= t . "1dd5f99679db9767530cfc20642a40a48bd479be") (:authors ("Shuguang Sun" .= "shuguang79@qq.com")) (:maintainers ("Shuguang Sun" . "shuguang79@qq.com")= ) (:maintainer "Shuguang Sun" . "shuguang79@qq.com") (:keywords "tools") (:= url . "https://github.com/ShuguangSun/python-view-data")) :signed nil) (:ur= l "https://github.com/ShuguangSun/python-view-data.git") nil) > package-vc-install("python-view-data" nil nil python-view-data) > funcall-interactively(package-vc-install "python-view-data" nil nil pyt= hon-view-data) > call-interactively(package-vc-install record nil) > command-execute(package-vc-install record) > execute-extended-command(nil "package-vc-install" "pac") > funcall-interactively(execute-extended-command nil "package-vc-install"= "pac") > call-interactively(execute-extended-command nil nil) > command-execute(execute-extended-command) > > and I can fix it with this: > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index db0cc515e46..979bbb343ed 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -526,6 +526,7 @@ package-vc--unpack-1 > (when-let* ((require-lines (lm-header-multiline "package-req= uires"))) > (thread-last > (mapconcat #'identity require-lines " ") > + ((lambda (line) (concat line "\n"))) What I don't get, is what adding a newline to the end of a string should change? (read-from-string "((emacs \"29.1\"))") ;=3D> (((emacs "29.1")) . 16) (read-from-string "((emacs \"29.1\"\n))") ;=3D> (((emacs "29.1")) . 17) > package-read-from-string > lm--prepare-package-dependencies > (nconc deps) > > But I'm shying away from reporting a bug because I can't find any recent > code changes that could cause this. > > Could someone help/confirm? I'm using Emacs 29. > > -- > --=20 Philip Kaludercic