magit attempting to use external editor (!) for commit

magit attempting to use external editor (!) for commit

[Eric S Fraga]

Hello all,

For some reason, starting today, after updating Emacs from git, when I
try to commit a change using magit, it tries to start up emacsclient
(maybe based on my EDITOR environment variable?).  It actually fails
whether I've started the server or not.  First of all, why would magit
want to do this given that I'm in Emacs already?  Has it always done
this?  Secondaly, what is it that I have done (or not done) to end up in
this situation?

I have reverted to using vc-* commands for the time being so I can keep
working but I do like using magit for selective commits.

Thank you,
eric

-- 
Eric S Fraga via Emacs 28.0.50 & org 9.4 on Debian bullseye/sid

Re: magit attempting to use external editor (!) for commit

[Robert Pluim]

>>>>> On Mon, 12 Oct 2020 17:59:17 +0100, Eric S Fraga <e.fraga@ucl.ac.uk> said:

    Eric> Hello all,
    Eric> For some reason, starting today, after updating Emacs from git, when I
    Eric> try to commit a change using magit, it tries to start up emacsclient
    Eric> (maybe based on my EDITOR environment variable?).  It actually fails
    Eric> whether I've started the server or not.  First of all, why would magit
    Eric> want to do this given that I'm in Emacs already?  Has it always done
    Eric> this?  Secondaly, what is it that I have done (or not done) to end up in
    Eric> this situation?

- Because itʼs providing the commit message to git using git's
  external editor support, which then needs to call back into emacs
- Yes
- The interface to emacsclient changed in emacs, which means the
  with-editor package needed to be adjusted. See
  <https://github.com/magit/with-editor/issues/82>
  and <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43716>

TL;DR update your with-editor package

    Eric> I have reverted to using vc-* commands for the time being so I can keep
    Eric> working but I do like using magit for selective commits.

I feel your pain

Robert
-- 

Re: magit attempting to use external editor (!) for commit

[Eric S Fraga]

On Monday, 12 Oct 2020 at 19:19, Robert Pluim wrote:
> TL;DR update your with-editor package

Thank you.  A package I did not even know I was using.  ;-)

Still seems strange to me that a package, like magit, so Emacs based,
would use an external editor for some of its functions.  But I can
understand why.

Thanks again,
eric

-- 
Eric S Fraga via Emacs 28.0.50 & org 9.4 on Debian bullseye/sid

Re: magit attempting to use external editor (!) for commit

[Óscar Fuentes]

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> On Monday, 12 Oct 2020 at 19:19, Robert Pluim wrote:
>> TL;DR update your with-editor package
>
> Thank you.  A package I did not even know I was using.  ;-)
>
> Still seems strange to me that a package, like magit, so Emacs based,
> would use an external editor for some of its functions.  But I can
> understand why.

Magit is not using an external editor, git is :-)

Re: magit attempting to use external editor (!) for commit

[Eric S Fraga]

On Tuesday, 13 Oct 2020 at 17:00, Óscar Fuentes wrote:
> Magit is not using an external editor, git is :-)

True, which I only learned now, so caught me by surprise.
All working so everything is good!

-- 
Eric S Fraga via Emacs 28.0.50 & org 9.4 on Debian bullseye/sid