From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: Re: [External] : interactive to do `use-region-p' Date: Sun, 06 Nov 2022 19:53:21 +0100 Message-ID: <87tu3bc3tq.fsf@dataswamp.org> References: <87o7tkci2t.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:7HgwYWbU+vIMyOtxc+f3brqN7yA= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 13:42:56 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os1Sq-000Aby-5U for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 13:42:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1os1SP-0001Lr-0P; Mon, 07 Nov 2022 07:42:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orklx-0002f6-KW for help-gnu-emacs@gnu.org; Sun, 06 Nov 2022 13:53:36 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orklv-0003W2-R1 for help-gnu-emacs@gnu.org; Sun, 06 Nov 2022 13:53:33 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1orklu-0002Za-0a for help-gnu-emacs@gnu.org; Sun, 06 Nov 2022 19:53:30 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 07 Nov 2022 07:42:09 -0500 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:140773 Archived-At: Drew Adams wrote: > But instead of (nil nil) you might prefer `(,(point-min) > ,(point-max)). This use case: It can be good to know if the user set the region or not, and if it's set it is obvious what the boundaries are, if unset, there are several courses of action and that one, while perhaps the most common one, isn't the only one, one can also think of ((point) (point-max)) and many other scenarios. So I think (nil nil) is best, signaling "not set by the user", then instead of asking `user-region-p' one can just check if BEG and END are set, if not one would explicitly have to set them to something that makes sense for that function. > (interactive > (let* ((regp (use-region-p)) > (st (if regp (region-beginning) (point-min))) > (en (if regp (region-end) (point-max)))) > (list st en))) Yes, they can still be nil nil from Lisp tho if &optional so then they have to be set outside of (after) `interactive' as well unless nil values make sense which often when dealing with the region and buffer positions they don't ... (defun gnus-summary-respool-all (&optional beg end) (interactive (when (use-region-p) (list (region-beginning) (region-end)) )) (or beg (setq beg (point-min))) (or end (setq end (point-max))) (let ((lines (count-lines beg end)) (method (gnus-find-method-for-group "nnml:mail.misc")) ) (goto-char beg) (gnus-summary-respool-article lines method) )) > `interactive' with string arg is OK, but often isn't TRT. TRT = The Right Thing > It can sometimes be clearer to just define a function that > does what you want, and use that with (interactive > `(,@(DTRT))). It can but it takes more time and the code gets longer so if you can use `interactive' without a function I think that is TRT :) And in this CASE it seems there isn't an uppercase "R" anyway so yeah, that's what I'm proposing ... -- underground experts united https://dataswamp.org/~incal