From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.help Subject: Re: A problem (apparently) connected with window point Date: Sat, 03 Apr 2021 05:25:35 +0200 Message-ID: <87r1js82xc.fsf@mbork.pl> References: <875z159val.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3738"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.1.0; emacs 28.0.50 Cc: help-gnu-emacs@gnu.org To: Stefan Monnier Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 03 05:26:27 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSWvb-0000o9-7r for geh-help-gnu-emacs@m.gmane-mx.org; Sat, 03 Apr 2021 05:26:27 +0200 Original-Received: from localhost ([::1]:58886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSWva-0001r6-8X for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 02 Apr 2021 23:26:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSWv6-0001qw-8v for help-gnu-emacs@gnu.org; Fri, 02 Apr 2021 23:25:56 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:57196) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSWv1-0006i0-2K for help-gnu-emacs@gnu.org; Fri, 02 Apr 2021 23:25:55 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 5C677E66FC; Sat, 3 Apr 2021 05:25:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PRYN9hHTshlv; Sat, 3 Apr 2021 05:25:43 +0200 (CEST) Original-Received: from localhost (178235147187.dynamic-3-poz-k-0-1-0.vectranet.pl [178.235.147.187]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 0126BE6250; Sat, 3 Apr 2021 05:25:42 +0200 (CEST) In-reply-to: Received-SPF: pass client-ip=195.110.48.8; envelope-from=mbork@mbork.pl; helo=mail.mojserwer.eu X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128827 Archived-At: On 2021-04-02, at 14:13, Stefan Monnier wrote: >> The problem is that `reorder-sentence-copy-word-at-point' inserts every >> word at the beginning of the buffer. (Try it, following the steps >> above.) I very much suspect that this is because of the window point: > > That's right. To avoid the problem you have to understand that > `(with-current-buffer reorder-sentence--buffer ...)` will select the > right buffer but will place point at a location that depends on what was > the last use of that buffer (and redisplay *is* a use of that buffer, > which is why having the buffer displayed makes a difference). > In your case I think you have two options: Thanks! I have to admit that I still don't get _why_ this is happening. Why would `with-current-buffer' do that -- it just uses `set-buffer' and `save-current-buffer' under the hood, and their docstrings don't mention anything like that. Isn't it a bug in the docs, then? > 1- Take it for granted that the buffer is displayed and make > `reorder-sentence-copy-word-at-point` move the corresponding > window-point (either by selecting that window around the `insert` or > by explicitly using `set-window-point`) and use that window-point as > the insertion point (so the user can move the cursor in that window > in order to insert word either at the end, beginning or elsewhere in > the temp buffer). > > 2- Use your own notion of "point", e.g. by calling (goto-char ) > before the `insert` and updating as you see fit. > In your example, I suspect using (point-max) for might do > the trick. I think both vaiants make sense - 1 is slightly better (and I guess doable via `get-buffer-window'), 2 is slightly simpler (and should cover 99.99% of the needs anyway). Thanks, -- Marcin Borkowski http://mbork.pl