unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: help-gnu-emacs@gnu.org
Subject: Re: Any way to control which articles Gnus summary shows by default?
Date: Tue, 10 Apr 2018 09:27:43 -0700	[thread overview]
Message-ID: <87po37jabk.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87po376yvq.fsf@web.de

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> The process as I'd like to have it looks more like (with code for
>> backwards compatibility removed):
>>
>> (defun eieio-persistent-fix-value (value)
>>   (let (result)
>>     (when (consp value)
>>       (if (class-p (car value))
>>           (setq result
>>                 (eieio-persistent-make-instance (car value) (cdr value))
>>                 value nil)
>>         (while (consp value)
>>           (push (eieio-persistent-fix-value (car value)) result)
>>           (setq value (cdr value)))))
>>     (if (eieio-object-p result)
>>         result
>>       (nconc (nreverse result)
>>              (if (stringp value)
>>                  (substring-no-properties value)
>>                value)))))
>
> There must be something missing: VALUEs that are not consp are never
> handled by this.

If VALUE isn't a consp, it falls through to the equivalent of:

(nconc (nreverse nil) value)

It might not be the most efficient (I'd really like to work on making
this whole process more efficient), but it comes out correctly. This
entire process shouldn't do anything but reconstruct objects, and strip
properties from strings.

> A minor problem with that approach is that `eieio-persistent-fix-value'
> (I would rather call it "eieio-persistent-restore-value") can't
> distinguish between objects and data that looks like an object.

That's the current state of the debate! There is a thread on emacs.devel
(or maybe a bug report, now I can't find it) from a while back where I
was discussing this with Stefan and others. We got as far as "there
should be no ambiguity/collisions about what's an object constructor and
what's a list." Then I got sidetracked by the continuing breakage of the
Gnus registry.

If you've got some ideas about this (very welcome!), maybe we should
move the discussion there.

Eric




  reply	other threads:[~2018-04-10 16:27 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.11583.1522744082.27995.help-gnu-emacs@gnu.org>
2018-04-03 23:17 ` Any way to control which articles Gnus summary shows by default? Emanuel Berg
2018-04-03 23:28   ` Emanuel Berg
2018-04-04  7:00   ` Michael Heerdegen
2018-04-04  7:30     ` Eric Abrahamsen
2018-04-04 10:59       ` Michael Heerdegen
2018-04-04 11:31         ` Eric Abrahamsen
2018-04-04 14:41           ` Michael Heerdegen
2018-04-04 14:46             ` Michael Heerdegen
2018-04-06 14:52             ` Michael Heerdegen
2018-04-06 15:22               ` Eric Abrahamsen
2018-04-06 17:53                 ` Eric Abrahamsen
2018-04-06 18:06                   ` Eric Abrahamsen
2018-04-07  9:26                     ` Michael Heerdegen
2018-04-07 12:33                       ` Michael Heerdegen
2018-04-07  9:23                   ` Michael Heerdegen
2018-04-08 14:17                   ` Michael Heerdegen
2018-04-08 15:03                     ` Eric Abrahamsen
2018-04-08 15:46                       ` Michael Heerdegen
2018-04-08 16:57                         ` Eric Abrahamsen
2018-04-08 19:01                         ` Eric Abrahamsen
2018-04-08 23:59                           ` Eric Abrahamsen
2018-04-09 14:12                             ` Michael Heerdegen
2018-04-09 16:36                               ` Eric Abrahamsen
2018-04-09 19:59                                 ` Michael Heerdegen
2018-04-09 20:18                                   ` Eric Abrahamsen
2018-04-10 12:15                                     ` Michael Heerdegen
2018-04-10 16:27                                       ` Eric Abrahamsen [this message]
2018-04-10 20:12                                         ` Michael Heerdegen
2018-04-10 22:29                                           ` Eric Abrahamsen
2018-04-11 17:05                                             ` Michael Heerdegen
     [not found]     ` <mailman.11665.1522827199.27995.help-gnu-emacs@gnu.org>
2018-04-04 12:43       ` Emanuel Berg
2018-04-06 17:53         ` Eric Abrahamsen
2018-07-24  3:10       ` Robert Girault
     [not found]   ` <mailman.11664.1522825278.27995.help-gnu-emacs@gnu.org>
2018-04-04 12:51     ` Emanuel Berg
2018-04-04 14:33       ` Michael Heerdegen
     [not found]       ` <mailman.11689.1522852442.27995.help-gnu-emacs@gnu.org>
2018-04-04 14:48         ` Emanuel Berg
2018-04-03  8:27 Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po37jabk.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).