From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.help Subject: Re: package-vc-install fails to build docs Date: Sun, 23 Apr 2023 09:54:19 -0700 Message-ID: <87pm7uedfa.fsf@breatheoutbreathe.in> References: <87a5z0sc3r.fsf@breatheoutbreathe.in> <871qkcl6kq.fsf@posteo.net> <877cu3o6ld.fsf@breatheoutbreathe.in> <877cu293l9.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23972"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org, Ruijie Yu To: Philip Kaludercic Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 23 19:07:02 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqdAz-00062n-Tr for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 23 Apr 2023 19:07:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqdAT-0006R3-HR; Sun, 23 Apr 2023 13:06:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqdAR-0006Qp-50 for help-gnu-emacs@gnu.org; Sun, 23 Apr 2023 13:06:27 -0400 Original-Received: from out-56.mta0.migadu.com ([2001:41d0:1004:224b::38]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqdAO-0002ui-JY for help-gnu-emacs@gnu.org; Sun, 23 Apr 2023 13:06:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1682269580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tz88Bh956S8crhX+oUPH0isY2Q+vf013Mg9BukYjo8g=; b=eAiEO5W4ti3+fkhf5tMb5dWtc704unVBfmJjGUumd6uVfdXzvx8Wbha3FI4JkxC8U7vwgf Zptd7tsWY248jJo2PuSjR1XXAIdmxaqS9vA7sCAXs1JBBy3XjQ2GEPGk83+yUn2dWewXUR QuTLml3fViapFhOhvGjU+GBmIJVDbz0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <877cu293l9.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::38; envelope-from=joseph@breatheoutbreathe.in; helo=out-56.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:143350 Archived-At: What would be the first steps to support :make in package-vc? Philip Kaludercic writes: > Joseph Turner writes: > >> Thank you Ruijie Yu and Philip Kaludercic for your help! >> >> Philip Kaludercic writes: >> >>> Ruijie Yu via Users list for the GNU Emacs text editor >>> writes: >>>> I'm looking at the package-vc source code, and it doesn't seem to try to >>>> autodetect any doc files at the moment. Try adding `:doc` in your >>>> `package-vc-install' call and see if anything changes. >> >> Actually, it looks like extra plist elements like :doc are stripped away >> in package-vc--unpack. package-vc--unpack doesn't pass its pkg-spec arg >> along to package-vc--unpack-1. package-vc--unpack-1 then calls >> package-vc--desc->spec, which gets the spec anew from ELPA IIUC. >> >> Regardless, I believe the issue lies elsewhere, see below. How shall we pass :doc and :make values from package-vc-install down to package-vc--build-documentation? Do we want to refactor package-vc-unpack-1 so that it accepts a pkg-spec argument? Or maybe add :doc an :make keys to the pkg-desc plist? > You are right (and I totally missed the :make entry in the specification > above). Package-vc did intentionally NOT add :make or :shell-command > support, for the sake of user safety. It wouldn't be difficult to > implement this, if we could find a way to make it reasonably safe > (e.g. if the user has to opt-in or we trust package specifications if > they were delivered by a trusted package archive). How about yes-or-no-p by default, with an customization option to automatically trust specs from a trusted package archive?