From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Better way to make sure external command exists in the system? Date: Tue, 23 Mar 2021 10:56:38 +0100 Message-ID: <87o8faxkfd.fsf@zoho.eu> References: <87y2ego29q.fsf@zoho.eu> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7904"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:42xhEPhsJ/BsqoxI9ZHp7eV+P9Y= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 23 10:58:12 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOdng-0001va-DV for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 23 Mar 2021 10:58:12 +0100 Original-Received: from localhost ([::1]:49448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOdnf-0002hK-Bs for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 23 Mar 2021 05:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOdmP-0001gt-W2 for help-gnu-emacs@gnu.org; Tue, 23 Mar 2021 05:56:54 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:57592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOdmO-00034G-DT for help-gnu-emacs@gnu.org; Tue, 23 Mar 2021 05:56:53 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lOdmL-00007l-NP for help-gnu-emacs@gnu.org; Tue, 23 Mar 2021 10:56:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128520 Archived-At: Jean Louis wrote: OK, let's see, straight X-Mas Eve this... > (defvar *image-default-resize-size* 1536) > (defvar *image-resize-sizes* '("1536" "1024" "800" "1200" "640")) The *common-lisp-convention* for global variables is disencourage in Elisp. Also, why the strings? > Argument FILE is image to be resized." > (if (rcd-which-list '("mogrify")) Not known to be defined: rcd-which-list (indeed I don't have it) Same with rcd-warning-message. > (let ((extension (file-name-extension file))) > (when (or (equal (downcase extension) "jpg") > (equal (downcase extension) "png")) Same thing twice, instead do let*. > (defun image-resize-dired () > "Resizes images." > (interactive) > (let ((files (dired-get-marked-files)) > (size (read-number "Size: " *image-default-resize-size* '(*image-resize-sizes*)))) HIST isn't used like that what I can see, read the `read-from-minibuffer' docstring. Does it even work? Also, why `read-number' and not in interactive? And, no need for globals if they are only used here. Use let* for that as well. Keep it on... -- underground experts united http://user.it.uu.se/~embe8573 https://dataswamp.org/~incal