From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.help Subject: Re: Debugging SMIE for sh-script.el Date: Sun, 12 Sep 2021 19:40:31 +0200 Message-ID: <87o88xwv3k.fsf@gmail.com> References: <87k0jz9rri.fsf@gmail.com> <04ae9f30-5e65-d7de-501e-92d557ddf84c@gmail.com> <87bl5ad5g4.fsf@gmail.com> <3b4cea5f-c08f-3307-655f-a43185ada5ee@gmail.com> <760e21aa-03ea-fb6c-5625-57493c59e455@gmail.com> <5542c259-2e3d-ce97-12ea-5e03d5c150a5@gmail.com> <829bc30d-41a7-c630-a568-00e7f18f1407@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8296"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: help-gnu-emacs@gnu.org, Stefan Monnier To: Nikolay Kudryavtsev Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 12 19:52:04 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPTe8-0001wC-9T for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 19:52:04 +0200 Original-Received: from localhost ([::1]:60232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPTe6-0005Qt-U7 for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 13:52:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPTT2-00077j-Ao for help-gnu-emacs@gnu.org; Sun, 12 Sep 2021 13:40:36 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:43570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPTT0-0004Kg-Nk for help-gnu-emacs@gnu.org; Sun, 12 Sep 2021 13:40:36 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id n7-20020a05600c3b8700b002f8ca941d89so4985241wms.2 for ; Sun, 12 Sep 2021 10:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=m91Vr81Zy+6M1jzXzxuu/iGqAbuqcKLzmdzC4gYmFuc=; b=c8aVdvVGsJd7wK9KlGVerEgBTbxYkpXCNq/4cnoy/aRLNuxcPD86iESO8J1P3JSrXA CUhEHIwsWz67xfd68gPzi+0b9/GSU4sfjUsW7MIzyeBPXg//zVGPGPKU7CSci1dP5qTY MRxtZZOovdmuqiihzyFSAAAknQDci8hYbqusgnq195vnNJ1tC8Jo0pMaIqO+5KusS5Q/ S8dYk7sgiXQOsqlYExuwhqAeOK7E7QkPVdUtL3tl/u5E8IDpU4IfYKO+F5yrVRHNe2oO tdCuEHTMkzFu0YHvVFSwF835dBCuhn/pAfUACYITOaFMMdfQBEifNZ53p5xehnDKFWtj RZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=m91Vr81Zy+6M1jzXzxuu/iGqAbuqcKLzmdzC4gYmFuc=; b=3aCirzacUuFbMZgIUdpcxmZ1iwYo3/Cc7k6M5jc8kjFe9a8I6Yitf0koXz6gpDkbx9 8nrF3rmTJgIs13Pw/WuDZBsHde9Folu/TpEqEjdoeOxWQ9seAo6SMAuaiK31QiqwsvzC 8FrHLFTVcjYsVdSF4edaZsEMHmH0zWvtktaLM926pYLnSeNUZRLz/xVKx25FEpjGI/rQ xdiViL0Yvwsoj4Ou9Sml/KkTS8UkY0wHEFWfleidyWjvvNCoKMQAm+Elkv+r0Hl8V1hs SsGx9wf+j63wV0ZaqJk/eJy8FgkoHcYt4AKqPp0kot7jOzimtS+FYqPYmLDCGxlCn/oG aD6Q== X-Gm-Message-State: AOAM530qVeRGGeV6M2nQGpuJBg4EPBHWDjij76aG5HpG/JQgZRxfaNQp XnOdkc/HOX5aOt3EIRu6tFnLQC3kRGw= X-Google-Smtp-Source: ABdhPJxjZyW/t8I78yZ56fCZwRjU2ySxoOnEztjfQqIJbr6k0+GovGKOrrH9soBbkk4MIjfLxFzOiw== X-Received: by 2002:a1c:19c6:: with SMTP id 189mr7563626wmz.174.1631468433128; Sun, 12 Sep 2021 10:40:33 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:20e:d340:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id c14sm5131647wrr.58.2021.09.12.10.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Sep 2021 10:40:32 -0700 (PDT) In-Reply-To: <829bc30d-41a7-c630-a568-00e7f18f1407@gmail.com> (Nikolay Kudryavtsev's message of "Mon, 6 Sep 2021 20:24:37 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:133012 Archived-At: Nikolay Kudryavtsev writes: > Anyway, I still think that even in this case, changing > sh-smie--indent-continuation is a better idea than touching the token > grab code. Just to test I've coded an implementation of it > , > that behaves correctly for Kevin's use case. Needs more testing, but > seems to work ok in general. Thanks for taking a stab at fixing that use-case; if I am not mistaken though, your implementation reverts Dario's good work from bug#44592: the test case Lars added fails when I run make -C test sh-script-tests. NB: I'm reporting this only for due diligence, since I'm the one who caused you to spend time on this issue. I don't want to waste more of your time on it; the current state of affairs isn't overly horrible. I've added this itch to my ever-growing pile; I might scratch it next time I open a shell script buffer, if no-one beats me to it :)