From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: EWW func add url under point as bookmark Date: Tue, 19 Apr 2022 02:24:07 +0200 Message-ID: <87o80xc448.fsf@zoho.eu> References: <87ilrb4gdu.fsf@gnu.org> <87pmli1n3t.fsf@gnu.org> <878rs6a0s2.fsf@zoho.eu> <87zgklumer.fsf@gnu.org> <87wnfooo8y.fsf@zoho.eu> <87wnfmqgny.fsf@gnu.org> <87tuaqazkk.fsf@zoho.eu> <87ilr6oxa7.fsf@gnu.org> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9469"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:i6zmH2d/HCI1EQwXbgFqS1h9d1c= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 20 18:39:20 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhDMO-0002Gp-SK for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 20 Apr 2022 18:39:20 +0200 Original-Received: from localhost ([::1]:47792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhDMN-0005Yo-GJ for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 20 Apr 2022 12:39:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngbfH-00034T-NN for help-gnu-emacs@gnu.org; Mon, 18 Apr 2022 20:24:19 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:49166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngbfG-0000We-57 for help-gnu-emacs@gnu.org; Mon, 18 Apr 2022 20:24:19 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ngbfD-00090W-CJ for help-gnu-emacs@gnu.org; Tue, 19 Apr 2022 02:24:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 20 Apr 2022 12:24:51 -0400 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:136972 Archived-At: Alex wrote: > PD: nice website Emanuel PD? thanks :) > Ok, now, Im browsing in EWW, and Im in a page with many > interesting urls, I want bookmarks all urls after point. Uhm, when you say URL, you mean hyperlink? > But moving the cursor, M-x eww-bookmark-add RET RET > with all urls is painfull. > > I need a func! > > #+begin_src elisp > > ;; Copyright 2022 Alex > ;; under GPLv3-or-later License > > (defun eww-bookmark-buffer-urls () > "Bookmark urls in current buffer" That's (to the) right, period. > (interactive) > (shr-next-link) > (let ((url-str (thing-at-point 'url))) I still think it better to check for nil here. > (if (save-excursion (shr-next-link)) > (eww-bookmark-buffer-urls))) Hm, that's look sa bit weird ... instead drop recursion and when you find what you are looking for, just get it and go on. (Should be `when' BTW as it stands.) > Works, but sadly stop when find an url already bookmarked :/ Sadly, you checked this in the other code and it is signalled as an error if it happens, sounds like overkill indeed.. -- underground experts united https://dataswamp.org/~incal