recognizing "end" correctly in Octave mode

recognizing "end" correctly in Octave mode

[Nicolas Neuss]

Hello,

Octave (which is similar to Matlab) allows both "end" and "end<op>" for
teminating constructs, e.g. I can write both "if ... endif" and "if
... end".  However, Octave mode does not recognize the "if ... end"
construct correctly (i.e. indentation is wrong).  Is it possible to change
this behaviour?

Thanks, Nicolas

Re: recognizing "end" correctly in Octave mode

[Dieter Wilhelm]

Nicolas Neuss <lastname@mathematik.uni-karlsruhe.de> writes:

> Hello,
>
> Octave (which is similar to Matlab) allows both "end" and "end<op>" for
> teminating constructs, e.g. I can write both "if ... endif" and "if
> ... end".  However, Octave mode does not recognize the "if ... end"
> construct correctly (i.e. indentation is wrong).  Is it possible to change
> this behaviour?

Yes, you could change the end keywords in the variable below:

(defvar octave-end-keywords
  '("end" "endfor" "endfunction" "endif" "endswitch" "end_try_catch"
    "end_unwind_protect" "endwhile"))

but according to this variable "end" is already a valid end-keyword.
Are you sure it doesn't work properly for "if ... end"?  Then there
might be a bug in the -calculate-indent function.

-- 
    Best wishes

    H. Dieter Wilhelm
    Darmstadt, Germany

Re: recognizing "end" correctly in Octave mode

[Nicolas Neuss]

Dieter Wilhelm <dieter@duenenhof-wilhelm.de> writes:

> Yes, you could change the end keywords in the variable below:
> 
> (defvar octave-end-keywords
>   '("end" "endfor" "endfunction" "endif" "endswitch" "end_try_catch"
>     "end_unwind_protect" "endwhile"))
> 
> but according to this variable "end" is already a valid end-keyword.
> Are you sure it doesn't work properly for "if ... end"?  Then there
> might be a bug in the -calculate-indent function.

Hmm, for me "end" was not included in this list (Emacs 21.4.1, Debian).
Unfortunately, including it does still not help.

This is how Octave mode wants to indent:

function A = LR3 (A0)
  A=A0;
  m=rows(A); n=columns(A);
  for i=1:min(m,n)
    A(i+1:m,i)=A(i+1:m,i)/A(i,i);
    A(i+1:m,i+1:n) = A(i+1:m,i+1:n)-A(i+1:m,i)*A(i,i+1:n);
    end
    end

Thank you, Nicolas

Re: recognizing "end" correctly in Octave mode

[Markus Triska]

Nicolas Neuss <lastname@mathematik.uni-karlsruhe.de> writes:

> This is how Octave mode wants to indent:
>
> function A = LR3 (A0)
>   A=A0;
>   m=rows(A); n=columns(A);
>   for i=1:min(m,n)
>     A(i+1:m,i)=A(i+1:m,i)/A(i,i);
>     A(i+1:m,i+1:n) = A(i+1:m,i+1:n)-A(i+1:m,i)*A(i,i+1:n);
>     end
>     end

indent-region on this gives:

function A = LR3 (A0)
  A=A0;
  m=rows(A); n=columns(A);
  for i=1:min(m,n)
    A(i+1:m,i)=A(i+1:m,i)/A(i,i);
    A(i+1:m,i+1:n) = A(i+1:m,i+1:n)-A(i+1:m,i)*A(i,i+1:n);
  end
end

in GNU Emacs 22.0.90.10.

All the best,
Markus Triska

Re: recognizing "end" correctly in Octave mode

[Dieter Wilhelm]

Markus Triska <triska@gmx.at> writes:

> Nicolas Neuss <lastname@mathematik.uni-karlsruhe.de> writes:
>
>> This is how Octave mode wants to indent:
>>
>> function A = LR3 (A0)
>>   A=A0;
>>   m=rows(A); n=columns(A);

...

>   for i=1:min(m,n)
>     A(i+1:m,i)=A(i+1:m,i)/A(i,i);
>     A(i+1:m,i+1:n) = A(i+1:m,i+1:n)-A(i+1:m,i)*A(i,i+1:n);
>   end
> end
>
> in GNU Emacs 22.0.90.10.
>

Yes thanks, forgot to mention that I had (as hopefully everybody on
this list Emacs 22), I'm sorry Nicolas, by the way, have you heard
about Emacs Calc, the great calculator mode in Emacs 22?  Might be
interesting for you.

-- 
    Best wishes

    H. Dieter Wilhelm
    Darmstadt, Germany