From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Emacs pretest: highlight line number in display-line-numbers-mode?
Date: Fri, 20 Oct 2017 15:49:07 +0200 [thread overview]
Message-ID: <87mv4mexpo.fsf@gmail.com> (raw)
In-Reply-To: <83376ee39c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Oct 2017 09:34:39 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Thu, 19 Oct 2017 13:43:06 -0700 (PDT)
>> From: Drew Adams <drew.adams@oracle.com>
>>
>> > This face is by default the same as line-number because of 2 reasons:
>> >
>> > . linum-mode did the same
>>
>> ...chasing that rabbit: Why did `linum-mode' do that?
>
> I don't know, but too many differences from a previous feature tend to
> annoy people IME.
nlinum-mode has an option to highlight the current line, disabled by
default (I never turned it on because I didn't know it existed, but I
do have it turned on for the builtin support)
I'd vote for having the current line face have a background colour
set. Calculating line numbers is going to slow things down anyway, so
a little less speed doesn't matter to me. Something like:
diff --git i/lisp/faces.el w/lisp/faces.el
index a5f1d1dd32..a2bb2cd1b3 100644
--- i/lisp/faces.el
+++ w/lisp/faces.el
@@ -2487,7 +2487,12 @@ line-number
:group 'display-line-numbers)
(defface line-number-current-line
- '((t :inherit line-number))
+ '((((class color) (background light))
+ :inherit line-number :background "grey95")
+ (((class color) (background dark))
+ :inherit line-number :background "grey10")
+ (t
+ :inherit line-number :background "gray"))
"Face for displaying the current line number.
This face is used when `display-line-numbers' is non-nil.
Robert
next prev parent reply other threads:[~2017-10-20 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 15:19 Emacs pretest: highlight line number in display-line-numbers-mode? Sivaram Neelakantan
2017-10-19 15:37 ` Robert Pluim
2017-10-19 17:18 ` Drew Adams
2017-10-19 20:09 ` Eli Zaretskii
[not found] ` <<834lquew6p.fsf@gnu.org>
2017-10-19 20:43 ` Drew Adams
2017-10-20 6:34 ` Eli Zaretskii
2017-10-20 13:49 ` Robert Pluim [this message]
2017-10-20 14:49 ` Eli Zaretskii
[not found] ` <<87mv4mexpo.fsf@gmail.com>
[not found] ` <<83h8utdgcq.fsf@gnu.org>
2017-10-20 15:18 ` Drew Adams
2017-10-20 15:42 ` Eli Zaretskii
[not found] ` <<83376ee39c.fsf@gnu.org>
2017-10-20 15:18 ` Drew Adams
2017-10-20 15:52 ` Eli Zaretskii
[not found] <<krpqx3tvyv413v.fsf@gmail.com>
[not found] <<<krpqx3tvyv413v.fsf@gmail.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv4mexpo.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).