From: John Shahid <jvshahid@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: help-gnu-emacs <help-gnu-emacs@gnu.org>
Subject: Re: call-process and incremental display of output
Date: Wed, 26 Dec 2018 12:47:12 -0500 [thread overview]
Message-ID: <87muosmb8f.fsf@gmail.com> (raw)
In-Reply-To: <jwv36szqj1d.fsf-monnier+emacs@gnu.org>
FYI, I have been using this patch without any noticeable issues. Not
sure if we should merge it.
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> Sounds good. I'll make the change locally and test it for a month or
>> two and report back.
>
> FWIW, I'm running with the following change now:
>
> diff --git a/src/editfns.c b/src/editfns.c
> index e995b38a44..db95a8a20a 100644
> --- a/src/editfns.c
> +++ b/src/editfns.c
> @@ -782,6 +782,12 @@ save_excursion_save (union specbinding *pdl)
> {
> eassert (pdl->unwind_excursion.kind == SPECPDL_UNWIND_EXCURSION);
> pdl->unwind_excursion.marker = Fpoint_marker ();
> + /* Suggested by John Shahid <jvshahid@gmail.com> in the "call-process and
> + * incremental display of output" thread of help-gnu-emacs.
> + * This matches the manually-created behavior of compile.el's process filter
> + * and probably others like comint as well. */
> + XMARKER (pdl->unwind_excursion.marker)->insertion_type
> + = !NILP (Vwindow_point_insertion_type);
> /* Selected window if current buffer is shown in it, nil otherwise. */
> pdl->unwind_excursion.window
> = (EQ (XWINDOW (selected_window)->contents, Fcurrent_buffer ())
>
> I haven't double checked that it does what I think it does, to be
> honest, but at least after a mere 48h of normal use I haven't noticed
> anything weird yet.
>
>
> Stefan
next prev parent reply other threads:[~2018-12-26 17:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 13:25 call-process and incremental display of output Florian Weimer
2018-10-16 14:21 ` Michael Albinus
2018-10-16 14:26 ` Florian Weimer
2018-10-16 14:32 ` Michael Albinus
2018-10-16 14:36 ` Stefan Monnier
2018-10-17 8:32 ` Florian Weimer
2018-10-17 9:21 ` tomas
2018-10-17 9:34 ` Florian Weimer
2018-10-17 9:40 ` tomas
2018-10-17 14:59 ` Stefan Monnier
2018-10-19 21:40 ` John Shahid
2018-10-19 22:05 ` Stefan Monnier
2018-10-19 23:52 ` John Shahid
2018-10-20 2:06 ` Stefan Monnier
2018-10-21 17:05 ` John Shahid
[not found] ` <jwv36szqj1d.fsf-monnier+emacs@gnu.org>
2018-12-26 17:47 ` John Shahid [this message]
2019-02-27 12:59 ` John Shahid
2019-02-27 14:11 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muosmb8f.fsf@gmail.com \
--to=jvshahid@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).