From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.help Subject: Re: package-vc-install bug? Date: Sun, 11 Feb 2024 09:28:41 +0000 Message-ID: <87mss7z6wm.fsf@posteo.net> References: <87bk8qov9f.fsf@gmx.net> <87wmrc498o.fsf@posteo.net> <87cyt49e3x.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: James Thomas Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 11 10:29:40 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZ69a-0009x4-AO for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 11 Feb 2024 10:29:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZ68n-0007Lp-R3; Sun, 11 Feb 2024 04:28:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ68l-0007Kh-N0 for help-gnu-emacs@gnu.org; Sun, 11 Feb 2024 04:28:47 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ68j-00075N-PB for help-gnu-emacs@gnu.org; Sun, 11 Feb 2024 04:28:47 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 07CBA240101 for ; Sun, 11 Feb 2024 10:28:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707643723; bh=OlRc838UO4HaerWnDRCagqY3ZNQSqwYg1OjGqDFOYXw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Type:From; b=XhiVckpSLt1SIp1SzkOJAwC5/pv3UuyA8AS5b387bdkxXyeBSZ8ZjKuUc5rYWcHUx sD7VZAv+XyNilKQfJlQ3+zyVP4HxtFwPhd72gHvkApoMjYHXM7WWgT1WJ51HV2YOUk sQ9rzuduRnx/OlSMHQcnX72q7mwv54UYIyNXKZCxcDS7Fte6FuTPwVovrMOReMDAQw OOSgPyjoMl0m0aQiW1KH8NWQAd4PpjVMRChkIWXjcazcdE7ZHRpqgRpKCJUHlmxoMa Kh03q3diXd0M/vnu0PR1GV7qTD0S3rcIuPusRiAGP0kO1+qG2dRXsS/iq9TTc8quAm 1QudRkmUWGyYA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TXj2L3KZmz6twJ; Sun, 11 Feb 2024 10:28:41 +0100 (CET) In-Reply-To: <87cyt49e3x.fsf@gmx.net> (James Thomas's message of "Sun, 11 Feb 2024 03:27:38 +0530") X-Hashcash: 1:20:240211:jimjoe@gmx.net::fRM723+kT9WaRXqw:iL1 X-Hashcash: 1:20:240211:help-gnu-emacs@gnu.org::wdxV/nK9ATQus21+:0D7O Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:145909 Archived-At: James Thomas writes: > Philip Kaludercic wrote: > >> James Thomas writes: >> >>> M-x package-vc-install RET RET fails with the following on my >>> system: >> >> Does this issue occur for every package? > > Yes, for every one I've tried (in my system). In that case this should be reported as a bug. >> What I don't get, is what adding a newline to the end of a string should >> change? >> >> (read-from-string "((emacs \"29.1\"))") ;=> (((emacs "29.1")) . 16) >> (read-from-string "((emacs \"29.1\"\n))") ;=> (((emacs "29.1")) . 17) > > The problem occurs in `package-read-from-string', not `read-from-string' I understood that, the point is that the cdr of the return value in both cases points to the end of the string, so the second `read-from-string' call in the `condition-case' will in both cases raise the same `end-of-file', as is the case here: (read-from-string "") (read-from-string "x" 1) > (I add the newline at the very end: "((emacs \"29.1\"))\n"): > > (defun package-read-from-string (str) > "Read a Lisp expression from STR. > Signal an error if the entire string was not used." > (pcase-let ((`(,expr . ,offset) (read-from-string str))) > (condition-case () > ;; The call to `ignore' suppresses a compiler warning. > (progn (ignore (read-from-string str offset)) > (error "Can't read whole string")) > (end-of-file expr)))) > > Because of the last line (`end-of-file') in the `condition-case'. Can you confirm this by using edebug? > Regards, > James -- Philip Kaludercic