unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Alexandre LAURENT <shaoner@gmail.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Overriding some face attributes without changing the default(s) one(s)
Date: Mon, 09 Jun 2014 10:26:01 +0400	[thread overview]
Message-ID: <87lht6ha4m.fsf@gmail.com> (raw)
In-Reply-To: <CAC8hHhmWMHu9x0GokUqDVfG3JX-Y-zVz3MhOsP23yu1oGV2a6A@mail.gmail.com> (Alexandre LAURENT's message of "Sun, 8 Jun 2014 22:23:10 +0200")

Alexandre LAURENT (2014-06-09 00:23 +0400) wrote:

> On Sun, Jun 8, 2014 at 8:02 AM, Alex Kost <alezost@gmail.com> wrote:
>>
>> The problem is that in emacs 24.3.1 default face specifications are
>> merged with the face specifications defined by a theme, so what you see
>> is a "bold" defined by your theme and the bits from a default spec.  In
>> emacs 24.4 (and in the current trunk) your theme would work as expected:
>> if a face is themed, then the default spec is ignored completely.
>>
>> If you want to make emacs 24.3.1 display only themed faces, you have to
>> override all the bits of the default spec in your theme (which sounds
>> horrible IMO), so for example the following should "free" your
> Yes it is horrible, I wanted to avoid that.
>> background:
>>
>> (custom-theme-set-faces
>>  'monokai-nox
>> ;; ...
>> '(whitespace-line ((t (:background unspecified :weight bold))))
> Actually, setting the foreground to unspecified does not work either.
> I'm pretty sure it takes the "default" face and this face only, which
> is different from the multiple faces applied when opening a source
> file (no matter what that source file is).
> I also define this default face in both my themes.

Oh, now I understand what you want.  Actually here you faced with
another problem: when you enable whitespace-mode in emacs 24.3.1,
"whitespace-line" becomes the only active face in a long line, and in
emacs 24.4 it is added to the faces in that line.

So let's say, you have the following long line in a buffer with
"emacs-lisp-mode" (and "whitespace-mode" is enabled):

(defun some-function (arg1 arg2 &rest args) "A very useful function." (interactive) (message "Hello"))

If you move your cursor to the "defun" word and press "C-4 C-x =", in
the bottom of the "*Help*" buffer you will see:

There are text properties here:
  face                 whitespace-line
  fontified            t

I.e. only "whitespace-line" face is active and you can't see
"font-lock-keyword-face" (used for highlighting "defun") no matter how
you customized "whitespace-line".

As for emacs 24.4, you will see:

There are text properties here:
  face                 (whitespace-line font-lock-keyword-face)
  fontified            t

In this case if some bits of face spec are unspecified in
"whitespace-line" face, the ones from "font-lock-keyword-face" are used.

So that is not the same problem we were discussing before, but it is
also fixed in emacs 24.4.

>> ;; ...
>> )
>>
>> If you are interested, I wrote something about that here:
>> <https://github.com/alezost/alect-themes/#emacs-2431-and-earlier>
>>
>> Also there were some related bugs, for example:
>> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16658>
>>
>> I hope it was helpful.
> Yes it is!
>
> Since I definitely need emacs24.4 for some other features/fix (ex: the
> rectangular region to be visually highlighted), I'll just wait for the
> package to be available on my distro.
>
> Thank you.




  reply	other threads:[~2014-06-09  6:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 11:32 Overriding some face attributes without changing the default(s) one(s) Alexandre LAURENT
2014-06-07  6:55 ` Alex Kost
2014-06-07 18:52 ` Michael Heerdegen
2014-06-07 23:09   ` Alexandre LAURENT
2014-06-08  6:02     ` Alex Kost
2014-06-08 20:23       ` Alexandre LAURENT
2014-06-09  6:26         ` Alex Kost [this message]
2014-06-09 18:10           ` Alexandre LAURENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lht6ha4m.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=shaoner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).