From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Hlavaty Newsgroups: gmane.emacs.help Subject: Re: make a drawing with Emacs Date: Thu, 03 Sep 2020 20:23:36 +0200 Message-ID: <87lfhqn2hj.fsf@logand.com> References: <20200901145854.GF15433@tuxteam.de> <87sgbzsx4q.fsf@logand.com> <87ft7zs48u.fsf@logand.com> <87d032u637.fsf@gnus.org> <878sdqu5v6.fsf@gnus.org> <874koeu52z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19499"; mail-complaints-to="usenet@ciao.gmane.io" To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 03 20:24:34 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDtuT-0004wc-M4 for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 03 Sep 2020 20:24:33 +0200 Original-Received: from localhost ([::1]:42610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDtuS-0001qL-P8 for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 03 Sep 2020 14:24:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDttd-0000hZ-MU for help-gnu-emacs@gnu.org; Thu, 03 Sep 2020 14:23:41 -0400 Original-Received: from logand.com ([37.48.87.44]:39402) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDttb-0001ky-MA for help-gnu-emacs@gnu.org; Thu, 03 Sep 2020 14:23:41 -0400 Original-Received: by logand.com (Postfix, from userid 1001) id AEEEE1A5422; Thu, 3 Sep 2020 20:23:37 +0200 (CEST) X-Mailer: emacs 26.3 (via feedmail 11-beta-1 I) In-Reply-To: <874koeu52z.fsf@gnus.org> Received-SPF: pass client-ip=37.48.87.44; envelope-from=tom@logand.com; helo=logand.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 13:55:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:123938 Archived-At: On Thu 03 Sep 2020 at 19:45, Lars Magne Ingebrigtsen wrote: > Stefan Monnier writes: > >> IIRC it would make the code slower, tho. It adds code like >> >> (let ((stroke-color (cadr (plist-member args :stroke-color)))) >> >> which the compiler fails to optimize away when `stroke-color` is not used. > > I didn't know that... but on the other hand, all these functions end up > calling this internal function: > > (defun svg--arguments (svg args) > (let ((stroke-width (or (plist-get args :stroke-width) > (dom-attr svg 'stroke-width))) > (stroke-color (or (plist-get args :stroke-color) > (dom-attr svg 'stroke-color))) > (fill-color (plist-get args :fill-color)) > attr) > > Which could then lose these plist-gets, so we'd end up with > approximately the same slowness, I think. :-) &allow-other-keys does not make sense for functions. svg--arguments is called in 9 places. Should it be possible to identify all relevant keys for each use-case or is that not reasonable for svg?