From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: How to rename files to numbers in Eshell? Date: Wed, 22 Sep 2021 16:27:46 +0200 Message-ID: <87k0j8lm71.fsf@zoho.eu> References: <87tuirckxp.fsf@inka.de> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:jc120N17/PpBxacPB++oxfI14/Q= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 22 16:28:52 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT3Ey-0006iR-PH for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 16:28:52 +0200 Original-Received: from localhost ([::1]:41854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT3Ex-0000R1-EC for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 10:28:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT3EA-0000QT-DD for help-gnu-emacs@gnu.org; Wed, 22 Sep 2021 10:28:02 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:38344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT3E6-0006ID-G3 for help-gnu-emacs@gnu.org; Wed, 22 Sep 2021 10:28:02 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mT3E4-0005NL-GA for help-gnu-emacs@gnu.org; Wed, 22 Sep 2021 16:27:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:133147 Archived-At: Jean Louis wrote: > This may serve as starting point: > > (defun renumber-files (&optional files) > "This function works within Dired or Directory Editor in GNU > Emacs. It will rename bunch of files and renumber them > automatically by date and number of the file. It is useful when > you are renaming less important images or bunch of files with > irrelevant file names." > (interactive) > (let* ((files (or files (dired-get-marked-files))) > (count 1)) > (dolist (file files) > (let* ((extension (file-name-extension file)) > (filename (format "%s-%06.f.%s" (format-time-string "%F") count extension))) > (rename-file file filename) > (setq count (+ count 1)))))) > > Then in eshell: > > $ renumber-files * That's the spirit Jean - we do _everything_ in Elisp, however the time, place, and manner of invocation is entirely optional and up to the user's preference and discretion. It's interface-agnostic (or client-agnostic) computing for YOU! However your style has, in your phrasing, "a bunch" of flaws ... as in formally Second line should not have indentation First line is not a complete sentence Argument ‘files’ should appear (as FILES) in the doc string The first `let*' does not have to be parallel but can be the sequential `let'. It also lacks a (require 'dired) because of `dired-get-marked-files'. And there is no need to increment the count manually with the error-prone out-of-baseline `setq' when you instead can have a twin iterate/increment loop with `cl-loop' _or_ if you insist to do it manually you still don't need setq but can use `cl-incf' and if you insist on setq you can still use `1+' But that's just me insisting! Wait, let's just increment manually ... +1 Sweet :) -- underground experts united https://dataswamp.org/~incal