version> and version>=

version> and version>=

[goncholden]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, February 1st, 2022 at 5:52 PM, Drew Adams <drew.adams@oracle.com> wrote:

> I have seen that the possible completions for version are:
>
> version<
>
> version<=
>
> Could there also be
>
> version>
>
> version>=

(not (version<= V1 V2))

(not (version< V1 V2))


What is the best way to check the version

(if (version< emacs-version "28.0")

or

(< emacs-version 28.0)

Re: version> and version>=

[Emanuel Berg via Users list for the GNU Emacs text editor]

goncholden wrote:

> What is the best way to check the version
>
> (version< emacs-version "28.0")

This, since it works.

BTW in Gnus article mode the paren highlight matches the right
parenthesis with the less-than sign ...

> or
>
> (< emacs-version 28.0)

DNC. Eval it to learn why ...

-- 
underground experts united
https://dataswamp.org/~incal

Re: version> and version>=

[Stefan Monnier via Users list for the GNU Emacs text editor]

> What is the best way to check the version
>
> (if (version< emacs-version "28.0")
>
> or
>
> (< emacs-version 28.0)

(< emacs-major-version 28)


        Stefan

version> and version>=

[goncholden]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, February 2nd, 2022 at 3:47 AM, Stefan Monnier via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> wrote:

> What is the best way to check the version
>
> (if (version< emacs-version "28.0")
>
> or
>
> (< emacs-version 28.0)

(< emacs-major-version 28)

Stefan

Am working on colouring comments according to whether the background is light or dark.

But I am encountering

if: Wrong type argument: number-or-marker-p, "27.2"


Code:

(defvar annotation-chroma
  '( (dark .  ((low  . "#8300E0")  (mid  . "#AA33FF")  (high . "#C370FF")))
     (light . ((low  . "#C16BFF")  (mid  . "#AA33FF")  (high . "#8000DB"))) )
  "Colour contrast for comments, indigo on dark and light background.")


(defun annotation-typeface (chroma)
  "Set the foreground colour for comments."

  (let* ( (colors annotation-chroma)
          (levels
           (if (>= emacs-version 28.0)
               (alist-get (frame--current-backround-mode nil) colors)
	     (message "GonCholden"))) )

    (face-remap-add-relative 'font-lock-comment-face
       `(:foreground ,(alist-get chroma levels)))

    (message "annotation: %s contrast" chroma)) )

Re: version> and version>=

[Tassilo Horn]

goncholden <goncholden@protonmail.com> writes:

>> (< emacs-version 28.0)
>
> (< emacs-major-version 28)
>
> Stefan
>
> Am working on colouring comments according to whether the background
> is light or dark.
>
> But I am encountering
>
> if: Wrong type argument: number-or-marker-p, "27.2"
>
>
> Code:
>            (if (>= emacs-version 28.0)

`emacs-version' is a string, 28.0 is a float.  You cannot compare them.
Stefan suggested to use `emacs-major-version' with 28 (both integers)
instead.

HTH,
Tassilo

version> and version>=

[goncholden]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, February 2nd, 2022 at 1:38 PM, Tassilo Horn <tsdh@gnu.org> wrote:

> goncholden goncholden@protonmail.com writes:
>
> > > (< emacs-version 28.0)
> >
> > (< emacs-major-version 28)
> >
> > Stefan
> >
> > Am working on colouring comments according to whether the background
> >
> > is light or dark.
> >
> > But I am encountering
> >
> > if: Wrong type argument: number-or-marker-p, "27.2"
> >
> > Code:
> >
> > (if (>= emacs-version 28.0)
>
> `emacs-version' is a string, 28.0 is a float. You cannot compare them. Stefan suggested to use` emacs-major-version' with 28 (both integers)
> instead.
>
> HTH,
> Tassilo

It would be convenient if there was a function that could handle floats, so that one can condition
not just on a major version, but upon the complete version number.

Re: version> and version>=

[Tassilo Horn]

goncholden <goncholden@protonmail.com> writes:

>> `emacs-version' is a string, 28.0 is a float. You cannot compare
>> them. Stefan suggested to use` emacs-major-version' with 28 (both
>> integers) instead.
>
> It would be convenient if there was a function that could handle
> floats, so that one can condition not just on a major version, but
> upon the complete version number.

Well, usually there should be no API-breaking changes between Emacs X.Y
und X.Z, so version-checks more detailed than major version shouldn't be
needed.

And there is already

  (version<= "28.0" emacs-version)

if you want to test with version strings and have more control over
minor and even micro version.  (Using floats for versions is just plain
wrong.)

Bye,
Tassilo

version> and version>=

[goncholden]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, February 2nd, 2022 at 1:52 PM, Tassilo Horn <tsdh@gnu.org> wrote:

> goncholden goncholden@protonmail.com writes:
>
> > > `emacs-version' is a string, 28.0 is a float. You cannot compare them. Stefan suggested to use` emacs-major-version' with 28 (both
> > > integers) instead.
> >
> > It would be convenient if there was a function that could handle
> > floats, so that one can condition not just on a major version, but
> > upon the complete version number.
>
> Well, usually there should be no API-breaking changes between Emacs X.Y
> und X.Z, so version-checks more detailed than major version shouldn't be
> needed.
>
> And there is already
>
> (version<= "28.0" emacs-version)
>
> if you want to test with version strings and have more control over
> minor and even micro version. (Using floats for versions is just plain
> wrong.)
>
> Bye,
> Tassilo

You make a good point about the "No API-Breaking Changes".   Then perhaps
(>= emacs-version "28.0") if one does not like floats.  Although there is
nothing wrong about floats because version numbers can easily be sorted
numerically.  In the old days, strings took over.  I wish scripts could
handle numeric computations better.

Re: version> and version>=

[Tassilo Horn]

goncholden <goncholden@protonmail.com> writes:

> Although there is nothing wrong about floats because version numbers
> can easily be sorted numerically.

No, they cannot.

ELISP> (sort '(1.2 1.12) #'<)
(1.12 1.2)

ELISP> (sort '("1.2" "1.12") #'version<)
("1.2" "1.12")

Also, the common version 0.1 (and many other fractions) cannot be
represented as a float.  0.1 is not really 0.1 which you only see if you
print enough digits:

*** Eval error ***  Format string ends in middle of format specifier
ELISP> (format "%.20f" 0.1)
"0.10000000000000000555"

Aside from that, versions tend to have the form major.minor.micro with
optionally even stuff like -<alpha|beta|rc><number> appended.  Hard to
encode into a float.

Bye,
Tassilo

Re: version> and version>=

[Tassilo Horn]

goncholden <goncholden@protonmail.com> writes:

>> `emacs-version' is a string, 28.0 is a float. You cannot compare
>> them. Stefan suggested to use` emacs-major-version' with 28 (both
>> integers) instead.
>
> It would be convenient if there was a function that could handle
> floats, so that one can condition not just on a major version, but
> upon the complete version number.

As said in my other mail, floats are not good for this because in math,
1.2 is greater than 1.10 but with versions, 1.10 is greater than 1.2.

See my other mail: if you really need to check major, minor, and maybe
even micro version, then use `version<' with the version strings.

Bye,
Tassilo

PS: Could you please teach your mail client not to remove the Re: from
    the subject of replies?  Every reply of yours looks like a new
    thread on first sight.

version> and version>=

[goncholden]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, February 2nd, 2022 at 2:15 PM, Tassilo Horn <tsdh@gnu.org> wrote:

> goncholden goncholden@protonmail.com writes:
>
> > > `emacs-version' is a string, 28.0 is a float. You cannot compare them. Stefan suggested to use` emacs-major-version' with 28 (both
> > >
> > > integers) instead.
> >
> > It would be convenient if there was a function that could handle
> >
> > floats, so that one can condition not just on a major version, but
> >
> > upon the complete version number.
>
> As said in my other mail, floats are not good for this because in math,
> 1.2 is greater than 1.10 but with versions, 1.10 is greater than 1.2.
> See my other mail: if you really need to check major, minor, and maybe
> even micro version, then use `version<' with the version strings.

I missed that, you are correct then.

> Bye,
> Tassilo


> PS: Could you please teach your mail client not to remove the Re: from
> the subject of replies? Every reply of yours looks like a new
> thread on first sight.

Ok, I thought the Re: should not be there.

Re: version> and version>=

[Tassilo Horn]

goncholden <goncholden@protonmail.com> writes:

>> PS: Could you please teach your mail client not to remove the Re:
>> from the subject of replies? Every reply of yours looks like a new
>> thread on first sight.
>
> Ok, I thought the Re: should not be there.

It should.  It clearly shows that this mail is a reply to another mail.
It is alright to remove successive Re:s, e.g., with

  Re: Re: AW: Re: version> and version>=

it's alright to strip down to

  Re: version> and version>=

because the additional Re:s and the "translated" AW: were inserted by
broken clients like Outlook.

Bye,
Tassilo

Re: version> and version>=

[Eli Zaretskii]

> Date: Wed, 02 Feb 2022 13:48:56 +0000
> From: goncholden <goncholden@protonmail.com>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, help-gnu-emacs@gnu.org
> 
> It would be convenient if there was a function that could handle floats, so that one can condition
> not just on a major version, but upon the complete version number.

We already have that: version< and similar functions.

Re: version> and version>=

[Yuri Khan]

On Wed, 2 Feb 2022 at 17:21, goncholden <goncholden@protonmail.com> wrote:

> > What is the best way to check the version
> >
> > (if (version< emacs-version "28.0")
> >
> > or
> >
> > (< emacs-version 28.0)

A typical case of the XY Problem. You want to solve X, you think Y
will help you, and you ask how to do Y. You will get helpful comments
on how to do Y, but miss out on all the better ways to do X.

> Am working on colouring comments according to whether the background is light or dark.

This is your original X. The solution to that is to look at
(frame-parameter nil 'background-mode), as told in the other thread.

> (frame--current-backround-mode nil)

This is your assumed solution, Y.

In fact, you have another case of XY here. You discover
‘frame--current-background-mode’ is not available in Emacs < 28. Your
actual problem is “how do I know a function is available in my Emacs”.
You assume you need to check the Emacs version, but in fact you should
check for features, not versions. (fboundp
'frame--current-background-mode) will return t if the function is
available, nil if not.

Re: version> and version>=

[goncholden]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, February 2nd, 2022 at 3:00 PM, Yuri Khan <yuri.v.khan@gmail.com> wrote:

> On Wed, 2 Feb 2022 at 17:21, goncholden goncholden@protonmail.com wrote:
>
> > > What is the best way to check the version
> > >
> > > (if (version< emacs-version "28.0")
> > >
> > > or
> > >
> > > (< emacs-version 28.0)
>
> A typical case of the XY Problem. You want to solve X, you think Y
>
> will help you, and you ask how to do Y. You will get helpful comments
>
> on how to do Y, but miss out on all the better ways to do X.
>
> > Am working on colouring comments according to whether the background is light or dark.
>
> This is your original X. The solution to that is to look at
>
> (frame-parameter nil 'background-mode), as told in the other thread.
>
> > (frame--current-backround-mode nil)
>
> This is your assumed solution, Y.
>
> In fact, you have another case of XY here. You discover
> ‘frame--current-background-mode’ is not available in Emacs < 28. Your
> actual problem is “how do I know a function is available in my Emacs”.
>
> You assume you need to check the Emacs version, but in fact you should
> check for features, not versions. (fboundp
> 'frame--current-background-mode) will return t if the function is
> available, nil if not.

Correct, the availability problem winded me up a little bit.

version> and version>=

[goncholden via Users list for the GNU Emacs text editor]

I have seen that the possible completions for version are:

version<
version<=

Could there also be

version>
version>=