unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Help Gnu Emacs mailing list <help-gnu-emacs@gnu.org>
Subject: Dynamically constructing advice behaves strangely
Date: Sun, 14 Feb 2016 15:59:50 +0100	[thread overview]
Message-ID: <87io1r2v89.fsf@mbork.pl> (raw)

Hi list,

I want to be able to construct advice dynamically.  Here is a "minimal
example":

--8<---------------cut here---------------start------------->8---
;;;   -*- lexical-binding: t; -*-

(defun add-constructed-advice (fun)
  "Add a constructed advice to function foo."
  (let* ((fun-name (symbol-name fun))
	 (length-sym
	  (make-symbol (concat "length-of-" fun-name)))
	 (piece-of-advice-sym
	  (make-symbol (concat "advice-for-" fun-name)))
	 (piece-of-advice (lambda (orig-fun &rest args)
			    (apply orig-fun args)
			    (message "This function's name had length %s."
				     (symbol-value length-sym)))))
    
    (set length-sym (length (symbol-name fun)))
    (fset piece-of-advice-sym piece-of-advice)
    (advice-add fun :around piece-of-advice-sym)))

(defun foo-fun ()
  ""
  (message "Function foo-fun run."))

(add-constructed-advice 'foo-fun)
--8<---------------cut here---------------end--------------->8---

This works (i.e., M-: foo-fun properly runs the advice), but I expected
the symbol `advice-for-foo-fun' to have this piece of advice in its
function cell - and it does not.  Why?

TIA,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University



             reply	other threads:[~2016-02-14 14:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14 14:59 Marcin Borkowski [this message]
2016-02-14 15:34 ` Dynamically constructing advice behaves strangely Michael Heerdegen
2016-02-14 20:57   ` Marcin Borkowski
2016-02-14 15:44 ` Michael Heerdegen
2016-02-14 20:58   ` Marcin Borkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io1r2v89.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).