From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: How to read an integer from the minibuffer Date: Tue, 16 Nov 2021 12:37:36 +0100 Message-ID: <87ilws1gcf.fsf@zoho.eu> References: <87ee7nqomk.fsf@mbork.pl> <875ysxrj0v.fsf@mbork.pl> <877dd835cp.fsf@zoho.eu> <87y25o1lv4.fsf@zoho.eu> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22136"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:NEKZySg4HnXNRprwD0Sb74zscZo= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 16 12:38:12 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmwmy-0005RN-3G for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 16 Nov 2021 12:38:12 +0100 Original-Received: from localhost ([::1]:38570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmwmw-0004KN-5g for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 16 Nov 2021 06:38:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmwmc-0004KE-N9 for help-gnu-emacs@gnu.org; Tue, 16 Nov 2021 06:37:50 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:55438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmwmb-0001AA-0N for help-gnu-emacs@gnu.org; Tue, 16 Nov 2021 06:37:50 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mmwmZ-0004rx-77 for help-gnu-emacs@gnu.org; Tue, 16 Nov 2021 12:37:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:134631 Archived-At: Yuri Khan wrote: > If you’re checking the input string by regexp anyway, you could do > that before calling the parser and simplify to: > > (defun string-to-number-strict (str) > (if (string-match > "^[+-]?\\([[:digit:]]+\\|[[:digit:]]*\\.[[:digit:]]+\\)$" s) > (string-to-number s) > (error "invalid number"))) > > Depending on circumstances, you might want to refine the > regexp to disallow leading zeros unless it is the only digit > in the integer part; and/or allow exponential format. Okay, so now we are getting somewhere ... I love the question mark. As for disallowing leading zeroes I think it should be as close to Emacs as possible, eval 00 for example. (defun string-to-number-number (str) (let ((s (string-trim str))) (when (string-match "^[+-]?\\([[:digit:]]+\\|[[:digit:]]*\\.[[:digit:]]+\\)$" s) (string-to-number s) ))) ;; (string-to-number-number " 10") ; 10 ;; (string-to-number-number " 1.5") ; 1.5 ;; (string-to-number-number " +0") ; 0 ;; (string-to-number-number " 0") ; 0 ;; (string-to-number-number " -0.0") ; -0.0 ;; (string-to-number-number " -1.5") ; 1.5 ;; (string-to-number-number "-10") ; -10 ;; (string-to-number-number "123this used to work") ; nil ;; (string-to-number-number "NAN") ; nil > It might also be a good idea to wrap all that in > a ‘save-match-data’.) What/how do you mean? -- underground experts united https://dataswamp.org/~incal