From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: Re: Virtual pet for Emacs Date: Thu, 05 May 2022 05:47:17 +0200 Message-ID: <87ilqkr67u.fsf@dataswamp.org> References: <267f98227b970b1385d062302c708dd4@riseup.net> <87r158r7he.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36574"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:muBHGEj62hgueE/ZF6VxSrHafjI= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 05:47:58 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmST7-0009Jf-V1 for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 05:47:57 +0200 Original-Received: from localhost ([::1]:55576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmST6-0005SP-Q5 for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 04 May 2022 23:47:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmSSf-0005Qs-SJ for help-gnu-emacs@gnu.org; Wed, 04 May 2022 23:47:29 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:46454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmSSd-0006vA-40 for help-gnu-emacs@gnu.org; Wed, 04 May 2022 23:47:29 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nmSSa-0008Up-OT for help-gnu-emacs@gnu.org; Thu, 05 May 2022 05:47:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:137128 Archived-At: >>> (defun points-to-evolution (total-points) >>> (dolist (points +pet-evolution-tree+) >>> (if (> (car points) total-points) >>> (return ;; <------------------- HERE >>> (nth 1 >>> (assoc (car points) +pet-evolution-tree+)))))) >> >> That should be `cl-dolist` and `cl-return`. > > Oh, so that's the intention, then rather than that use > a list (higher-order) function! That code has a lot of things that can be improved, - get away with `cl-return', use for example `cl-find-if' instead - don't do (car points) twice - don't search the list twice (first `cl-dolist', then `assoc') - better names: if "points" are extracted from the pet-evolution (remove the CL naming conventions with plus signs around a constant; also there is no reason to say what data structure a data structure is in its name, cmp. `user-full-name' not "user-full-name-string") I actually think all or almost all will be fixed if the first issue is fixed ... -- underground experts united https://dataswamp.org/~incal