Re: Virtual pet for Emacs

[Emanuel Berg <incal@dataswamp.org>]

>>> (defun points-to-evolution (total-points)
>>>   (dolist (points +pet-evolution-tree+)
>>>     (if (> (car points) total-points)
>>> 	(return ;; <------------------- HERE
>>> 	 (nth 1
>>> 	  (assoc (car points) +pet-evolution-tree+))))))
>>
>> That should be `cl-dolist` and `cl-return`.
>
> Oh, so that's the intention, then rather than that use
> a list (higher-order) function!

That code has a lot of things that can be improved,

- get away with `cl-return', use for example `cl-find-if'
  instead

- don't do (car points) twice

- don't search the list twice (first `cl-dolist', then
  `assoc')

- better names: if "points" are extracted from the
  pet-evolution (remove the CL naming conventions with plus
  signs around a constant; also there is no reason to say what
  data structure a data structure is in its name, cmp.
  `user-full-name' not "user-full-name-string")

I actually think all or almost all will be fixed if the first
issue is fixed ...

-- 
underground experts united
https://dataswamp.org/~incal