From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.help Subject: Re: How to handle default value in read-string? Date: Tue, 04 Aug 2015 01:40:16 +0200 Message-ID: <87h9og9c0v.fsf@mbork.pl> References: <87k2tc9jeu.fsf@mbork.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438645260 18665 80.91.229.3 (3 Aug 2015 23:41:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Aug 2015 23:41:00 +0000 (UTC) To: Help Gnu Emacs mailing list Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Aug 04 01:40:53 2015 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZMPLh-0007UJ-09 for geh-help-gnu-emacs@m.gmane.org; Tue, 04 Aug 2015 01:40:53 +0200 Original-Received: from localhost ([::1]:60770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMPLf-0000h9-UW for geh-help-gnu-emacs@m.gmane.org; Mon, 03 Aug 2015 19:40:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMPLS-0000gm-Cd for help-gnu-emacs@gnu.org; Mon, 03 Aug 2015 19:40:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMPLN-000093-6p for help-gnu-emacs@gnu.org; Mon, 03 Aug 2015 19:40:38 -0400 Original-Received: from mail.mojserwer.eu ([2a01:5e00:2:52::8]:60117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMPLM-00008P-TA for help-gnu-emacs@gnu.org; Mon, 03 Aug 2015 19:40:33 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id ABC106F2004 for ; Tue, 4 Aug 2015 01:40:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y1Sy4BP4iAFN for ; Tue, 4 Aug 2015 01:40:28 +0200 (CEST) Original-Received: from localhost (cdn32.neoplus.adsl.tpnet.pl [83.30.163.32]) by mail.mojserwer.eu (Postfix) with ESMTPSA id DD2666F2003 for ; Tue, 4 Aug 2015 01:40:27 +0200 (CEST) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:5e00:2:52::8 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:106224 Archived-At: On 2015-08-03, at 23:17, John Mastro wrote: >> I'd like read-string to somehow indicate the default value. A natural >> idea is to include it in the prompt, for example having a prompt like >> >> (format "Foo (%s): " default) >> >> However, Icicles' version of read-string already does exactly that, so >> for Icicles users this would be superfluous. >> >> So here's the question: is there a better way than just have a prompt of >> >> (if icicle-mode (don't-include-default) (do-include-default))? > > There's no getting around that you'll need a condition somewhere. Well, that was more or less obvious... However, your suggestion of bound-and-true-p (below) is (obviously) a significant improvement for anyone without Icicles loaded:-). Thanks! > However, you can of course wrap it up in a helper function, so you're > not repeating the condition every time you use `read-string'. > > (defun my-read-string (prompt &optional ...) > (unless (bound-and-true-p icicle-mode) > (setq prompt (concat prompt " (%s)" default))) > (read-string prompt ...)) > > You could use advice to do the same thing but I don't think it would be > an improvement in this case. Thanks a lot! -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University