unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
* profiler-report seems to be missing data?
@ 2018-08-15 15:00 Charlie Andrews
  2018-08-15 18:46 ` Eli Zaretskii
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Charlie Andrews @ 2018-08-15 15:00 UTC (permalink / raw)
  To: help-gnu-emacs

I'm trying to profile the usually excellent `find-things-fast` package to
figure out why it's slow in my project.

I started profiling with `profiler-start`, executed the command that's slow
(`ftf-find-file`), then immediately ran `profiler-report`.

This generated the following report:

    Functions                                                 CPU samples  %
    - command-execute                                                1770
88%
     - call-interactively                                            1770
88%
      - apply                                                        1770
88%
       - call-interactively@ido-cr+-record-current-command
 1770  88%
        - apply                                                      1770
88%
         - #<subr call-interactively>                                1770
88%
          - funcall-interactively                                    1770
88%
           - ftf-find-file                                           1597
80%
            - ftf-project-files-alist                                1522
76%
             - ftf-project-files-hash                                1330
66%
              - let                                                  1330
66%
               - mapcar                                              1330
66%
                - #<lambda 0x5458e8e0>                               1024
51%
                 - let*                                              1008
50%
                    cons                                               24
 1%
                + split-string                                        282
14%
             + maphash                                                192
 9%
            + ido-completing-read                                      67
 3%
           + next-line                                                 75
 3%
           + ido-switch-buffer                                         41
 2%
           + ido-switch-buffer-other-window                            38
 1%
           + profiler-report                                           19
 0%
    + ...                                                             145
 7%
    + redisplay_internal (C function)                                  37
 1%
    + timer-event-handler                                              26
 1%
      undefined                                                         5
 0%
    + gui-set-selection                                                 4
 0%
      internal-echo-keystrokes-prefix                                   2
 0%

The profiler report seems to blame the `let*` function within
`ftf-project-files-hash`.

However, looking at that function:

    (defun ftf-project-files-hash ()
      "Returns a hashtable filled with file names as the key and "
      (let ((default-directory (ftf-project-directory))
            (table (make-hash-table :test 'equal)))
        (mapcar (lambda (file)
                  (let* ((file-name (file-name-nondirectory file))
                         (full-path (expand-file-name file))
                         (pathlist (cons full-path (gethash file-name table
nil))))
                    (puthash file-name pathlist table)))
                (split-string (ftf-project-files-string)))
        table))

It seems incredibly unlikely that `let*` is the slow part, but rather one
of the functions called within that `let*`.

Why is `profiler-report` stopping at `let*` rather than telling me which
component of that `let*` is slow? How can I dig deeper to find which
exactly function is slow?

(FWIW, I've tried increasing profiler-max-stack-depth from 16 to 30 to no
avail.)


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2018-08-19  5:06 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-15 15:00 profiler-report seems to be missing data? Charlie Andrews
2018-08-15 18:46 ` Eli Zaretskii
2018-08-16 13:47 ` Charlie Andrews
2018-08-16 14:19   ` Eli Zaretskii
2018-08-16 15:32     ` Michael Heerdegen
2018-08-16 17:12       ` Charlie Andrews
2018-08-16 17:28         ` Eli Zaretskii
2018-08-16 17:33           ` Charlie Andrews
2018-08-16 18:00             ` Eli Zaretskii
2018-08-16 18:48               ` Michael Heerdegen
2018-08-16 18:59                 ` Eli Zaretskii
2018-08-16 18:54         ` Michael Heerdegen
2018-08-16 22:47 ` Stefan Monnier
2018-08-17 15:36   ` Charlie Andrews
2018-08-19  5:06     ` Stefan Monnier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).