From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: How to rename files to numbers in Eshell? Date: Wed, 22 Sep 2021 16:46:28 +0200 Message-ID: <87fstwllbv.fsf@zoho.eu> References: <87tuirckxp.fsf@inka.de> <87ee9u2neh.fsf@inka.de> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8326"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:UsWEDaQUtyZggJNTfRSbBBsrNL0= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 22 16:47:50 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT3XH-0001kj-Ot for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 16:47:47 +0200 Original-Received: from localhost ([::1]:53758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT3XF-0001wh-OC for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 10:47:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT3WK-0001vt-V2 for help-gnu-emacs@gnu.org; Wed, 22 Sep 2021 10:46:49 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:49814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT3WF-0004dc-QM for help-gnu-emacs@gnu.org; Wed, 22 Sep 2021 10:46:47 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mT3WE-000Ack-1V for help-gnu-emacs@gnu.org; Wed, 22 Sep 2021 16:46:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:133149 Archived-At: Jean Louis wrote: > (defun rcd-image-date-match (file) > (string-match "[[:digit:]][[:digit:]][[:digit:]][[:digit:]][[:digit:]][[:digit:]][[:digit:]][[:digit:]][_-]" file)) Badness 1632321754: use the postfix operator for repitition, \{n\} > (defun sort-images (&optional prefix) Badness 1632321536: unused lexical argument > (dir (concat "/home/data1/protected/Media/Pictures/Pictures/Year-" year "/" month "/" year "-" month "-" day "/")) > (destination (concat "/home/data1/protected/Media/Pictures/Pictures/Year-" year "/" month "/" year "-" month "-" day "/" file-base "." file-ext))) Badness 1632321545: same data hard-coded twice (damn) > (mkdir dir t) > (message (concat "Copy file to: " destination)) Badness 1632321563: "destination" should be spelled "dst" to line up with "src", also it is just too long and bulky even for Lisp. > (if (y-or-n-p (concat "Overwrite: " destination)) > (rename-file file destination t)) Badness 1632321690: `if' with only one branch should be `when'. Conclusion: Hey, no one said it's supposed to be easy ... -- underground experts united https://dataswamp.org/~incal