* help-mode-finish obsolete?
@ 2022-05-28 3:40 Emanuel Berg
2022-05-29 19:39 ` Daniel Martín
0 siblings, 1 reply; 5+ messages in thread
From: Emanuel Berg @ 2022-05-28 3:40 UTC (permalink / raw)
To: help-gnu-emacs
This function is obsolete since 29.1.
So how do you do this then?
(defun help-mode-finish-after ()
(forward-button 1) )
(advice-add #'help-mode-finish :after #'help-mode-finish-after)
https://dataswamp.org/~incal/emacs-init/help-incal.el
--
underground experts united
https://dataswamp.org/~incal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode-finish obsolete?
2022-05-28 3:40 help-mode-finish obsolete? Emanuel Berg
@ 2022-05-29 19:39 ` Daniel Martín
2022-05-29 23:39 ` Emanuel Berg
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Martín @ 2022-05-29 19:39 UTC (permalink / raw)
To: help-gnu-emacs
Emanuel Berg <incal@dataswamp.org> writes:
> This function is obsolete since 29.1.
>
> So how do you do this then?
>
> (defun help-mode-finish-after ()
> (forward-button 1) )
> (advice-add #'help-mode-finish :after #'help-mode-finish-after)
>
> https://dataswamp.org/~incal/emacs-init/help-incal.el
I see that the deprecated functions help-mode-setup and help-mode-finish
are still called from with-output-to-temp-buffer, which is not updated
yet. I'd report that as a bug, suggesting that the deprecation message
should also explain what's the preferred API to use.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: help-mode-finish obsolete?
2022-05-29 19:39 ` Daniel Martín
@ 2022-05-29 23:39 ` Emanuel Berg
2022-05-29 23:41 ` Emanuel Berg
2022-05-30 3:37 ` Michael Heerdegen
2 siblings, 0 replies; 5+ messages in thread
From: Emanuel Berg @ 2022-05-29 23:39 UTC (permalink / raw)
To: help-gnu-emacs
Daniel Martín wrote:
>> This function is obsolete since 29.1.
>>
>> So how do you do this then?
>>
>> (defun help-mode-finish-after ()
>> (forward-button 1) )
>> (advice-add #'help-mode-finish :after #'help-mode-finish-after)
>>
>> https://dataswamp.org/~incal/emacs-init/help-incal.el
>
> I see that the deprecated functions help-mode-setup and
> help-mode-finish are still called from
> with-output-to-temp-buffer, which is not updated yet.
> I'd report that as a bug, suggesting that the deprecation
> message should also explain what's the preferred API to use.
In a way I agree, just take a look at this line:
(advice-add #'help-mode-finish :after #'help-mode-finish-after)
:)
--
underground experts united
https://dataswamp.org/~incal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode-finish obsolete?
2022-05-29 19:39 ` Daniel Martín
2022-05-29 23:39 ` Emanuel Berg
@ 2022-05-29 23:41 ` Emanuel Berg
2022-05-30 3:37 ` Michael Heerdegen
2 siblings, 0 replies; 5+ messages in thread
From: Emanuel Berg @ 2022-05-29 23:41 UTC (permalink / raw)
To: help-gnu-emacs
Daniel Martín wrote:
>> This function is obsolete since 29.1.
>>
>> So how do you do this then?
>>
>> (defun help-mode-finish-after ()
>> (forward-button 1) )
>> (advice-add #'help-mode-finish :after #'help-mode-finish-after)
>>
>> https://dataswamp.org/~incal/emacs-init/help-incal.el
>
> I see that the deprecated functions help-mode-setup and
> help-mode-finish are still called from
> with-output-to-temp-buffer, which is not updated yet.
> I'd report that as a bug, suggesting that the deprecation
> message should also explain what's the preferred API to use.
Maybe they will be merged with `help-mode' so the answer is do
the same but advice that instead?
--
underground experts united
https://dataswamp.org/~incal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode-finish obsolete?
2022-05-29 19:39 ` Daniel Martín
2022-05-29 23:39 ` Emanuel Berg
2022-05-29 23:41 ` Emanuel Berg
@ 2022-05-30 3:37 ` Michael Heerdegen
2 siblings, 0 replies; 5+ messages in thread
From: Michael Heerdegen @ 2022-05-30 3:37 UTC (permalink / raw)
To: help-gnu-emacs
Daniel Martín <mardani29@yahoo.es> writes:
> I see that the deprecated functions help-mode-setup and help-mode-finish
> are still called from with-output-to-temp-buffer, which is not updated
> yet. I'd report that as a bug, suggesting that the deprecation message
> should also explain what's the preferred API to use.
I think a bug report would not be wrong.
Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-30 3:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-28 3:40 help-mode-finish obsolete? Emanuel Berg
2022-05-29 19:39 ` Daniel Martín
2022-05-29 23:39 ` Emanuel Berg
2022-05-29 23:41 ` Emanuel Berg
2022-05-30 3:37 ` Michael Heerdegen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).