From: Michael Heerdegen <michael_heerdegen@web.de>
To: help-gnu-emacs@gnu.org
Subject: Re: replacing a function with another one
Date: Sun, 09 Mar 2014 23:02:05 +0100 [thread overview]
Message-ID: <87eh2b6nfm.fsf@web.de> (raw)
In-Reply-To: 8738ir161u.fsf@yun.yagibdah.de
lee <lee@yun.yagibdah.de> writes:
> So I guess should use advice-add instead --- and I can´t figure out how
> to get that to work. I need to access the argument passed to the
> function the advice is for, too. I tried to find examples, without
> success.
IMHO the best description how the advice types work is in C-h f
add-function.
> What I have is:
>
>
> (defadvice hi-lock-set-file-patterns (after
> lsl-hi-lock-set-file-patterns-advice activate)
> (setq hi-lock-interactive-patterns (ad-get-arg 0)))
> How would I do the same with add-advice (or whatever is appropriate)?
(advice-add
'hi-lock-set-file-patterns :after
(lambda (patterns)
(setq hi-lock-interactive-patterns patterns)))
You can also give the piece of advice a name like in defadvice:
(advice-add
'hi-lock-set-file-patterns :after
(lambda (patterns)
(setq hi-lock-interactive-patterns patterns))
'((name . lsl-hi-lock-set-file-patterns-advice)))
But you can instead just name the function instead of using an anonymous
one:
(defun my-hi-lock-set-file-patterns-after-ad (patterns)
(setq hi-lock-interactive-patterns patterns))
(advice-add 'hi-lock-set-file-patterns
:after 'my-hi-lock-set-file-patterns-after-ad)
The advantage is that advices are functions with the new implementation,
so referring to arguments and return values works transparently, instead
of the need of using obscure pseudo variables.
See C-h f add-function to learn how the other advice types work.
> Yes, that´s exactly what I´m trying to avoid. There is no way to detect
> when something changes in hi-lock.el in such a way that what I´m doing
> doesn´t work anymore, or is there?
No, not direct way.
> Suddenly finding out that what I´m trying to do doesn´t work anymore
> won´t be so great.
Indeed. But if you only rely on documented behavior (docstring), the
risk is low, since changes are backwards compatible most of the time.
> One change I´m thinking about is keeping the highlighting-patterns in a
> separate buffer and applying them to several buffers. That way, you can
> have several files that all use the same highlighting-patterns which
> were generated on the fly, centralised for the whole project (or some
> files of it). That´ll probably require quite a few modifications.
Don't hesitate to ask when you've questions, but I think you're on a
good way.
Regards,
Michael.
next prev parent reply other threads:[~2014-03-09 22:02 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 19:43 replacing a function with another one lee
2014-03-08 19:54 ` Eli Zaretskii
2014-03-09 1:17 ` lee
2014-03-08 22:30 ` Michael Heerdegen
2014-03-09 17:58 ` lee
2014-03-09 19:10 ` Michael Heerdegen
2014-03-09 20:57 ` lee
2014-03-09 22:02 ` Michael Heerdegen [this message]
2014-03-10 0:53 ` lee
2014-03-10 2:18 ` Michael Heerdegen
2014-03-10 15:29 ` lee
2014-03-11 0:03 ` Michael Heerdegen
2014-03-11 13:34 ` lee
2014-03-11 23:40 ` Michael Heerdegen
2014-03-12 6:11 ` Michael Heerdegen
2014-03-12 7:07 ` Michael Heerdegen
2014-03-12 14:48 ` lee
2014-03-13 7:19 ` Michael Heerdegen
2014-03-15 19:51 ` lee
2014-03-17 12:00 ` Michael Heerdegen
2014-03-12 14:04 ` lee
2014-03-12 18:26 ` Stefan Monnier
2014-03-12 4:10 ` Michael Heerdegen
2014-03-10 12:44 ` Stefan Monnier
2014-03-10 23:35 ` lee
2014-03-11 0:41 ` Michael Heerdegen
2014-03-11 1:45 ` Michael Heerdegen
2014-03-11 19:05 ` lee
2014-03-11 22:58 ` Michael Heerdegen
2014-03-12 15:11 ` lee
2014-03-12 18:15 ` Stefan Monnier
2014-03-12 21:43 ` lee
2014-03-13 7:22 ` Michael Heerdegen
2014-03-15 20:02 ` lee
2014-03-11 4:11 ` lee
2014-03-11 5:01 ` Michael Heerdegen
2014-03-11 14:25 ` lee
2014-03-11 23:51 ` Michael Heerdegen
2014-03-12 15:22 ` lee
2014-03-13 7:33 ` Michael Heerdegen
2014-03-13 12:29 ` Stefan Monnier
2014-03-15 20:05 ` lee
2014-03-16 17:20 ` Stefan
2014-03-11 6:51 ` Michael Heerdegen
2014-03-11 15:41 ` lee
2014-03-11 23:21 ` Michael Heerdegen
2014-03-12 17:33 ` lee
2014-03-12 19:34 ` Florian Beck
2014-03-12 19:51 ` Florian Beck
2014-03-13 7:54 ` Michael Heerdegen
2014-03-15 20:14 ` lee
2014-03-12 12:45 ` Stefan Monnier
2014-03-12 17:42 ` lee
2014-03-13 2:43 ` Jambunathan K
2014-03-15 20:17 ` How to propose an emacs patch (Re: replacing a function with another one) lee
2014-03-16 3:21 ` Jambunathan K
2014-03-17 4:35 ` lee
2014-03-10 13:45 ` replacing a function with another one lee
2014-03-10 23:31 ` Michael Heerdegen
2014-03-12 13:16 ` Jambunathan K
2014-03-12 13:18 ` Jambunathan K
2014-03-15 20:22 ` lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh2b6nfm.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).