From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.help Subject: Re: package-autoremove ? Date: Fri, 25 Aug 2023 10:40:34 +0200 Message-ID: <87cyzbqzbm.fsf@gnu.org> References: <87cyzbtvv8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27461"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.15; emacs 30.0.50 Cc: David Masterson , Rudolf Schlatte , help-gnu-emacs@gnu.org To: Philip Kaludercic Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 25 10:52:52 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZSYm-0006pT-KD for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 25 Aug 2023 10:52:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZSY1-0006kP-Hj; Fri, 25 Aug 2023 04:52:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZSXz-0006jj-VK for help-gnu-emacs@gnu.org; Fri, 25 Aug 2023 04:52:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZSXz-0003no-CA; Fri, 25 Aug 2023 04:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=CzMyH4kgQeiXfq3D6+Hzq9LT1pAWqR6Se1X9UxYCnn8=; b=ciYWPXm57mjASR 59Zil3/FHNB0iYuSl7b6tRG+ltiR2VB2O7IshZWM1xpmmHDxi20lk5hm5EGNDsRtwPI6vH/tfjETQ ObkEfq9lHQsCd4gj6HQ2GtNIzRxpYG0rY8C7K43AwzAdB5dFr9PhoVec8XBXL0n2i/YVxvrCR569I 4DBCu8kFVtxwNF7JtxfHEMG/1/FX7hckeIF3nIZqR08gdnoArA51jA6aSSNnv4gaZK1S5yzAz/ibu G5c/4MWIxu4khA/JOdYktj4rZebNYw8XoLVPNx1EkvOu4z+T343wYimMttcUhmv6XPeZgl8y8++rs sS9U2VsjSdDrIakfmBsQ==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvkedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dujedtheduvdelffejkeetgedvheelhedvueefhfeukeekkeehvdfggeegffevgfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-reply-to: <87cyzbtvv8.fsf@posteo.net> X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:144957 Archived-At: Philip Kaludercic writes: Hi Philip, >>> For me, this situation comes up when I install a package via >>> `(use-package ... :ensure t)' instead of via `list-packages'. >> >> Sounds like a good possibility for me as well. Someone should adjust >> use-package to add the package to package-selected-packages for this >> reason. My Lisp isn't that good. > > The :ensure keyword for use-package should select the packages, since > it invokes `package-install' without setting the optional DONT-SELECT > argument (use-package-ensure.el): > > --8<---------------cut here---------------start------------->8--- > ... > (if (assoc package package-archive-contents) > (package-install package) > (package-refresh-contents) > (when (assoc package (bound-and-true-p > package-pinned-packages)) > (package-read-all-archive-contents)) > (package-install package)) > ... > --8<---------------cut here---------------end--------------->8--- > > What might be an issue, is that package-install tries to save the > modification of `package-selected-packages' to disk (package.el): > > --8<---------------cut here---------------start------------->8--- > (if after-init-time > (customize-save-variable 'package-selected-packages package-selected-packages) > (add-hook 'after-init-hook #'package--save-selected-packages)) > --8<---------------cut here---------------end--------------->8--- > > Now if you have customised `custom-file' and/or don't load the > contents of the file, then upon restarting Emacs the updated value > would be lost and package-autoremove would suggest removing all the > packages installed by use-package (but also package-install, for that > matter). Very good analysis. I'm also affected by that issue and indeed, I have customized custom-file, because I use the very same user-init-file on multiple machines but put minor machine-related tweaks in custom-file. Basically, my user-init-file starts with: --8<---------------cut here---------------start------------->8--- (setopt custom-file (expand-file-name "custom.el" (if user-init-file (file-name-directory user-init-file) "~/.emacs.d/"))) (load custom-file t) --8<---------------cut here---------------end--------------->8--- Now on two machines which should have pretty much the same emacs setup (pretty current git master with the same init.el containing the same use-package with :ensure t statements), package-autoremove suggests different removal sets. The union of both sets contains many packages installed by use-package which are certainly wrong. It would be great if that could be fixed. Bye, Tassilo