From: Marcin Borkowski <mbork@mbork.pl>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: help-gnu-emacs@gnu.org
Subject: Re: A strange issue with buffer-undo-list
Date: Mon, 08 Mar 2021 22:42:21 +0100 [thread overview]
Message-ID: <87blbtiapu.fsf@mbork.pl> (raw)
In-Reply-To: <875z2f8xai.fsf@web.de>
On 2021-02-26, at 01:53, Michael Heerdegen <michael_heerdegen@web.de> wrote:
> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> Still, these "change groups" seem a strange feature to me - they are
>> hardly ever used in Emacs itself, right?
>
> Seems so. Where they are used - e.g. in the implementation of
> `transpose-subr', they are important however. You wouldn't want that
> undoing a transposition would happen in multiple steps uncovering
> implementation details.
Agreed, although I don't think undo would kick in within one command
(without explicit undo boundaries).
> Could be in other places they would also be appropriate but were
> forgotten. May also be that automatic undo amalgamation conceals cases
> were change group applications are missing.
As above - isn't it rather that unless you put explicit undo boundaries,
they are only inserted when the command loop takes over?
>
> BTW, in master your code example now works without errors, the problem
> has been fixed (by Stefan). And your code also works as you intend. I
> have tried. It doesn't work as intended however when using
> `undo-tree-mode' (another minor bug I would say).
Thanks for the answer, and sorry for the delay. Yes, I noticed it's
fixed; I don't use undo-tree.
Best,
--
Marcin Borkowski
http://mbork.pl
next prev parent reply other threads:[~2021-03-08 21:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 5:19 A strange issue with buffer-undo-list Marcin Borkowski
2021-02-24 0:43 ` Michael Heerdegen
2021-02-25 5:16 ` Marcin Borkowski
2021-02-25 5:28 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-02-25 14:19 ` Stefan Monnier
2021-02-25 15:58 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-03-08 21:43 ` Marcin Borkowski
2021-02-26 0:53 ` Michael Heerdegen
2021-03-08 21:42 ` Marcin Borkowski [this message]
2021-03-09 0:32 ` Michael Heerdegen
2021-03-09 21:22 ` Marcin Borkowski
2021-02-24 2:11 ` Michael Heerdegen
2021-02-24 3:33 ` Michael Heerdegen
2021-02-24 4:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blbtiapu.fsf@mbork.pl \
--to=mbork@mbork.pl \
--cc=help-gnu-emacs@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).