From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Stefan Monnier via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Debugging SMIE for sh-script.el
Date: Thu, 02 Sep 2021 23:37:47 +0200 [thread overview]
Message-ID: <87bl5ad5g4.fsf@gmail.com> (raw)
In-Reply-To: <jwv35qmg3o0.fsf-monnier+emacs@gnu.org> (Stefan Monnier via Users list for the's message of "Thu, 02 Sep 2021 15:50:14 -0400")
Stefan Monnier via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org> writes:
> Indeed, the problem seems to be in `sh-smie-sh-forward-token` where it
> should skip over the whole of "${foo}/bar".
Mmm, I see that with point on "--baz", (smie-backward-sexp) stops at
"/bar" instead of going all the way back to bol.
I'm tracking this down to sh-smie--default-backward-token, which makes
sense: this is where I tentatively added "()" in the call to
(skip-syntax-backward ".w_'") in 6392bc37a.
bug#50320 showed that this causes all paired delimiters (parentheses and
braces) to turn into tokens that smie-backward-sexp can jump to, so this
got misindented:
#+begin_src sh
foo ()
{
bar # derp
}
#+end_src
If I understand correctly, the progn form in
sh-smie--default-backward-token…
1. skips over chars matching syntax classes ".w_'",
2. skips over backslashes.
I guess TRT would be to add a third step to check whether (char-before
(point)) is a closing delimiter, and if so, skip back to its matching
opener? With (forward-sexp -1)? And then assert whether we've hit a $
sign?
No idea whether this makes sense. I don't mind implementing that and
seeing how it goes, but I'd like to make sure I'm not completely off the
mark…
next prev parent reply other threads:[~2021-09-02 21:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 10:49 Debugging SMIE for sh-script.el Kévin Le Gouguec
2021-09-02 12:07 ` Nikolay Kudryavtsev
2021-09-02 17:19 ` Kévin Le Gouguec
2021-09-02 18:09 ` Nikolay Kudryavtsev
2021-09-02 20:29 ` Kévin Le Gouguec
2021-09-02 19:50 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 21:37 ` Kévin Le Gouguec [this message]
2021-09-02 23:54 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-03 7:09 ` Kévin Le Gouguec
2021-09-03 12:12 ` Stefan Monnier
2021-09-05 15:48 ` Nikolay Kudryavtsev
2021-09-05 16:27 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 16:41 ` Nikolay Kudryavtsev
2021-09-05 17:23 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 18:01 ` Nikolay Kudryavtsev
2021-09-05 23:02 ` Stefan Monnier
2021-09-06 12:47 ` Nikolay Kudryavtsev
2021-09-06 14:01 ` Stefan Monnier
2021-09-06 17:24 ` Nikolay Kudryavtsev
2021-09-06 20:23 ` Stefan Monnier
2021-09-12 17:40 ` Kévin Le Gouguec
2021-09-02 19:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 20:39 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl5ad5g4.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).