unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: James Thomas <jimjoe@gmx.net>
To: help-gnu-emacs@gnu.org
Cc: Philip Kaludercic <philipk@posteo.net>
Subject: package-vc-install bug?
Date: Fri, 09 Feb 2024 14:43:32 +0530	[thread overview]
Message-ID: <87bk8qov9f.fsf@gmx.net> (raw)

M-x package-vc-install RET <package> RET fails with the following on my
system:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (error "Can’t read whole string")
  signal(error ("Can’t read whole string"))
  error("Can't read whole string")
  package-read-from-string("((emacs \"28.1\") (python \"0.2\") (csv-mode \"1.12\"))")
  package-vc--unpack-1(#s(package-desc :name python-view-data :version (20230508 543) :summary "View data in python" :reqs ((emacs (28 1)) (python (0 2)) (csv-mode (1 12))) :kind vc :archive "melpa" :dir "/home/user/.emacs.d/elpa/python-view-data/" :extras ((:commit . "1dd5f99679db9767530cfc20642a40a48bd479be") (:authors ("Shuguang Sun" . "shuguang79@qq.com")) (:maintainers ("Shuguang Sun" . "shuguang79@qq.com")) (:maintainer "Shuguang Sun" . "shuguang79@qq.com") (:keywords "tools") (:url . "https://github.com/ShuguangSun/python-view-data")) :signed nil) "/home/user/.emacs.d/elpa/python-view-data/")
  package-vc--unpack(#s(package-desc :name python-view-data :version (20230508 543) :summary "View data in python" :reqs ((emacs (28 1)) (python (0 2)) (csv-mode (1 12))) :kind tar :archive "melpa" :dir nil :extras ((:commit . "1dd5f99679db9767530cfc20642a40a48bd479be") (:authors ("Shuguang Sun" . "shuguang79@qq.com")) (:maintainers ("Shuguang Sun" . "shuguang79@qq.com")) (:maintainer "Shuguang Sun" . "shuguang79@qq.com") (:keywords "tools") (:url . "https://github.com/ShuguangSun/python-view-data")) :signed nil) (:url "https://github.com/ShuguangSun/python-view-data.git") nil)
  package-vc-install("python-view-data" nil nil python-view-data)
  funcall-interactively(package-vc-install "python-view-data" nil nil python-view-data)
  call-interactively(package-vc-install record nil)
  command-execute(package-vc-install record)
  execute-extended-command(nil "package-vc-install" "pac")
  funcall-interactively(execute-extended-command nil "package-vc-install" "pac")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)
--8<---------------cut here---------------end--------------->8---

and I can fix it with this:

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index db0cc515e46..979bbb343ed 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -526,6 +526,7 @@ package-vc--unpack-1
             (when-let* ((require-lines (lm-header-multiline "package-requires")))
               (thread-last
                 (mapconcat #'identity require-lines " ")
+                ((lambda (line) (concat line "\n")))
                 package-read-from-string
                 lm--prepare-package-dependencies
                 (nconc deps)

But I'm shying away from reporting a bug because I can't find any recent
code changes that could cause this.

Could someone help/confirm? I'm using Emacs 29.

--



             reply	other threads:[~2024-02-09  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09  9:13 James Thomas [this message]
2024-02-10 15:41 ` package-vc-install bug? Philip Kaludercic
2024-02-10 21:57   ` James Thomas
2024-02-11  9:28     ` Philip Kaludercic
2024-02-11 12:01       ` James Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk8qov9f.fsf@gmx.net \
    --to=jimjoe@gmx.net \
    --cc=help-gnu-emacs@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).