From: Philip Kaludercic <philipk@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Stefan Monnier via Users list for the GNU Emacs text editor
<help-gnu-emacs@gnu.org>
Subject: Re: Working around the limitations of SMIE
Date: Sun, 13 Nov 2022 00:12:24 +0000 [thread overview]
Message-ID: <87a64vyaon.fsf@posteo.net> (raw)
In-Reply-To: <jwvy1sgm23d.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 12 Nov 2022 14:06:14 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> I am writing a major mode for a little language I am using at
>>>> university, and wanted to try using SMIE for indentation and all the
>>>> other things. The issue I find myself confronted with is that functions
>>>> are defined as in the following example:
>>>>
>>>> func funktion(x : int): float
>>>> x := x * x;
>>>> return x;
>>>> end
>>>>
>>>> where there is no delimiter between the return type (float), and the
>>>> rest of the body (such as "begin" or something like that).
>>>
>>> How is the separation between the function's return type and the
>>> function's body defined? Is it based on the newline that follows the
>>> type, or is the language constrained to have types that are
>>> a single identifiers?
>>
>> The latter. This is the grammar production:
>>
>> functionDeclaration: ' func ' identifier '( ' ( parameterDeclaration ( ', '
>> parameterDeclaration ) * ) ? ') '
>> ( ': ' typeName ) ? block ' end ' ;
>
> Hmm... so the only "reliable" separator token is the close parenthesis, huh?
> I think I'd go with a hack in the lexer which checks if this is "the
> close paren of a function definition" and make it include the subsequent
> type annotation (if present). I.e. that new token would cover the whole of
>
> ')' ( ':' typeName ) ?
>
> Then again, that wouldn't work with the usual handling of parens in SMIE
> (IOW, you couldn't rely on syntax tables for them any more) :-(
>
> Maybe instead you can try and make the lexer recognize just ": typeName"
> (treating it as a special token) and then tweak the indentation rules so
> as to align the subsequent instruction with it.
I have managed to solve by making the tokenizer distinguish if it is
looking at the function type with or without any whitespace inbetween.
If there is, a ghost token is generated, if not the type token is
returned. This appears to work well.
Thanks for the hint, once again!
prev parent reply other threads:[~2022-11-13 0:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 21:25 Working around the limitations of SMIE Philip Kaludercic
2022-11-10 5:00 ` Stefan Monnier via Users list for the GNU Emacs text editor
2022-11-11 16:20 ` Philip Kaludercic
2022-11-12 19:06 ` Stefan Monnier
2022-11-13 0:12 ` Philip Kaludercic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a64vyaon.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=help-gnu-emacs@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).