unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Thorsten Jolitz <tjolitz@gmail.com>, help-gnu-emacs@gnu.org
Subject: Re: Bug in outline-magic.el
Date: Mon, 01 Jul 2013 01:00:13 +0200	[thread overview]
Message-ID: <878v1rp5ky.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <871u7j48ok.fsf@steelpick.2x.cz>

Hi Thorsten,

On Sun, Jun 30 2013, Michal Sojka wrote:
> On Fri, Jun 28 2013, Thorsten Jolitz wrote:
>> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>>
>> Hi Michal,
>>
>>> I think that there is a bug in outline-magic.el. See below. I put the
>>> same text also at
>>> http://www.emacswiki.org/emacs/Comments_on_outline-magic.el.
>>
>> I kind of took over outline-magic.el from Carsten when I merged it into
>> outshine.el and he asked me if I want to be the new maintainer.
>
> outshine.el seems interesting. I think I'll give it a try.

I've just looked at outshine.el and I like the idea. What I don't like
is that it does not work in buffers without "modern" headers such as
LaTeX, programming languages etc. where outline-magic worked. In my
opinion, the strength of outline-magic is that it works the same in all
major modes that set outline-regexp reasonably.

From the quick look at the code, it seems that you try to detect the
presence of "modern" headers in files (at least elisp files). It would
be nice if you could change outshine to work like outline-magic when
modern headers are not detected. I also miss the functionality to fold
elisp defuns with outshine.

Therefore, I'll stay with outline-magic. The bug I reported is present
even in your version so I've sent you a pull request over github.

Thanks,
-Michal



  parent reply	other threads:[~2013-06-30 23:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 16:06 Bug in outline-magic.el Michal Sojka
2013-06-28 16:59 ` Thorsten Jolitz
2013-06-30 20:58   ` Michal Sojka
2013-06-30 22:07     ` Thorsten Jolitz
2013-06-30 23:00     ` Michal Sojka [this message]
2013-06-30 23:51       ` Thorsten Jolitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v1rp5ky.fsf@steelpick.2x.cz \
    --to=sojkam1@fel.cvut.cz \
    --cc=help-gnu-emacs@gnu.org \
    --cc=tjolitz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).