How to exclude a major mode from a hook

How to exclude a major mode from a hook

[Cecil Westerhof]

I had the following in my .emacs:
    (add-hook 'before-save-hook 'delete-trailing-whitespace)

But I also use Gnus and a signature starts with '-- ' and now the
space is deleted and it is not a signature anymore.

So I rewrote it to:
    (add-hook 'before-save-hook (lambda () (when (not (string= major-mode "message-mode"))
                                             'delete-trailing-whitespace)))

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: How to exclude a major mode from a hook

[Fabrice Niessen]

Cecil Westerhof wrote:
> I had the following in my .emacs:
>     (add-hook 'before-save-hook 'delete-trailing-whitespace)
>
> But I also use Gnus and a signature starts with '-- ' and now the
> space is deleted and it is not a signature anymore.
>
> So I rewrote it to:
>     (add-hook 'before-save-hook (lambda () (when (not (string= major-mode "message-mode"))
>                                              'delete-trailing-whitespace)))

I do have:

--8<---------------cut here---------------start------------->8---
  ;; Nuke all trailing whitespaces in the buffer.
  (add-hook 'before-save-hook
            (lambda ()                  ; Except for ...
              (unless (or (eq major-mode 'message-mode)
                                        ; ... where "-- " is the signature
                                        ; separator (for when using emacsclient
                                        ; to compose emails and doing C-x #).
                          (eq major-mode 'diff-mode))
                                        ; ... where the patch file can't be
                                        ; changed!
                (delete-trailing-whitespace))))
--8<---------------cut here---------------end--------------->8---

Best regards,
Fabrice

-- 
Fabrice Niessen
Leuven, Belgium
http://www.pirilampo.org/

Re: How to exclude a major mode from a hook

[Cecil Westerhof]

Op Wednesday 11 Feb 2015 10:50 CET schreef Fabrice Niessen:

> Cecil Westerhof wrote:
>> I had the following in my .emacs:
>> (add-hook 'before-save-hook 'delete-trailing-whitespace)
>>
>> But I also use Gnus and a signature starts with '-- ' and now the
>> space is deleted and it is not a signature anymore.
>>
>> So I rewrote it to: (add-hook 'before-save-hook (lambda () (when
>> (not (string= major-mode "message-mode"))
>> 'delete-trailing-whitespace)))
>
> I do have:
>
> ;; Nuke all trailing whitespaces in the buffer.
> (add-hook 'before-save-hook
> (lambda ()                  ; Except for ...
> (unless (or (eq major-mode 'message-mode)
> ; ... where "-- " is the signature
> ; separator (for when using emacsclient
> ; to compose emails and doing C-x #).
> (eq major-mode 'diff-mode))
> ; ... where the patch file can't be
> ; changed!
> (delete-trailing-whitespace))))

At the moment I do not use diff-mode, but it does not hurt to add it.
;-)

Also your solution is a little more clear. (unless instead of not)

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: How to exclude a major mode from a hook

[Nicolas Richard]

Hi,

Cecil Westerhof <Cecil@decebal.nl> writes:
> I had the following in my .emacs:
>     (add-hook 'before-save-hook 'delete-trailing-whitespace)

IMO this is not the right thing to do, because one day you'll want to
edit a file in which trailing white spaces are important and you'll
wonder why it's all screwed up.

I would suggest to use a function that checks for trailing whitespaces
(with exceptions, such as the signature delimiter in message-mode) and
(interactievly) prompts if there is something to fix. I don't know if
such a function exists.

> So I rewrote it to:
>     (add-hook 'before-save-hook (lambda () (when (not (string= major-mode "message-mode"))
>                                              'delete-trailing-whitespace)))

The condition
    (string= major-mode "message-mode")
can be written as
    (eq major-mode 'message-mode)
and would be better written as
    (derived-mode-p 'message-mode)

-- 
Nicolas

Re: How to exclude a major mode from a hook

[Robert Thorpe]

Nicolas Richard <theonewiththeevillook@yahoo.fr> writes:

> Hi,
>
> Cecil Westerhof <Cecil@decebal.nl> writes:
>> I had the following in my .emacs:
>>     (add-hook 'before-save-hook 'delete-trailing-whitespace)
>
> IMO this is not the right thing to do, because one day you'll want to
> edit a file in which trailing white spaces are important and you'll
> wonder why it's all screwed up.

I agree.  It's much better to use an inclusive method for things like
this.  Find the programming languages and text modes that you care about
and only hook those.  It's not very hard, and when you think about it
the list is probably less than 20 items.  Doing it this way also means
you can (eventually) put the add-hook in a section of your init file
devoted to that a group of related language modes which makes it easier
to understand.

BR,