unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: help-gnu-emacs@gnu.org
Subject: Re: Cycle Auto-Fill
Date: Sun, 06 Dec 2020 00:53:33 +0100	[thread overview]
Message-ID: <878sabizcy.fsf@web.de> (raw)
In-Reply-To: trinity-5e8d739e-3312-4500-985c-6844d300e780-1607207938508@3c-app-mailcom-bs06

Christopher Dimech <dimech@gmx.com> writes:

> It is warning me about variable n.

[ This thread and "Removing line and column number settings from some
buffers" have converged into the same exactly same state.  I wonder how
often that happens. ]

Yes, and it's a useful warning: the variable is "free", which means its
usage would interfere with other free usages of this variable.

In your code the variable seems to be a redundant duplication of the
value stored in (get 'gungadin-auto-fill-cycle 'state), so I would just
get rid of it.

But - a different issue: note that you are currently using one (global)
state to remember a (buffer) local feature.  I think you don't really
want it like this.  You probably won't get happy when you are using this
in multiple buffers at the same time.  That's where a variable gets
useful: it can be buffer local.  I would drop the
`gungadin-auto-fill-cycle' symbol property instead: symbol properties
are always global.  Of course could you save and maintain a table of the
states of all buffers there, but that would be rather exotic and
complex.


Regards,

Michael.




  reply	other threads:[~2020-12-05 23:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05 13:25 Cycle Auto-Fill Christopher Dimech
2020-12-05 13:59 ` Pankaj Jangid
2020-12-05 14:16   ` Christopher Dimech
2020-12-05 16:57     ` Pankaj Jangid
2020-12-05 14:39 ` Ergus
2020-12-05 22:00 ` Michael Heerdegen
2020-12-05 22:06   ` Drew Adams
2020-12-05 22:38   ` Christopher Dimech
2020-12-05 23:53     ` Michael Heerdegen [this message]
     [not found]       ` <trinity-3598b15c-19a1-41d1-92ed-96e7f10f1fd9-1607213433613@3c-app-mailcom-bs06>
     [not found]         ` <87v9dfhj2e.fsf@web.de>
2020-12-06  0:49           ` Christopher Dimech
2020-12-06  2:33             ` Michael Heerdegen
2020-12-06  3:35               ` Christopher Dimech
2020-12-06  5:23                 ` Robert Thorpe
2020-12-06 23:01                 ` Michael Heerdegen
2020-12-06 23:43                   ` Christopher Dimech
2020-12-07  0:36                     ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sabizcy.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).