From: Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Separating colour and positioning functioning
Date: Mon, 08 Feb 2021 22:37:38 +0100 [thread overview]
Message-ID: <878s7yp7fh.fsf@zoho.eu> (raw)
In-Reply-To: trinity-3f0971fe-5919-46d5-9e74-c8b1711f519a-1612796537578@3c-app-mailcom-bs01
Christopher Dimech wrote:
> Have written a minor mode with part of the the code below
> and want to modify tex-typeface-crucible so that the colour
> scheme is enabled when the minor-mode is on.
I got the following warnings from the byte compiler:
Warning: defface for ‘colour-tex-cruc’ fails to specify containing group
Warning: reference to free variable ‘crucible-supinf-enable’
Warning: reference to free variable ‘crucible-supinf-vshift’
Warning: reference to free variable ‘supinf-font-lock-cruc’
Style PO-lice:
> (defface colour-tex-cruc
US English is preferable, then it becomes consistent. The user
shouldn't have think, "is the programmer a 'bloke' or
a 'dude'?" ...
> '( (default :inherit bold)
> ( ((class color) (min-colors 88) (background light))
> :foreground "#FF0000" )
> ( ((class color) (min-colors 88) (background dark))
> :foreground "#FF0000")
> (t :inherit font-lock-builtin-face) )
> "Typeface for tex keywords.")
Avoid hard-coding the same data (88 and "#FF0000") repeatedly.
Normally, the method is to use `let'.
> (defun supinf-disable-cruc (beg end)
> "Set typeface for text between BEG and END."
> (font-lock-default-unfontify-region beg end)
> (while (< beg end)
> (let ((next (next-single-property-change beg 'display nil end))
> (prop (get-text-property beg 'display)))
> (if (and (eq (car-safe prop) 'raise)
`if' -> `while'
> (member (car-safe (cdr prop)) crucible-supinf-vshift)
> (null (cddr prop)))
> (put-text-property beg next 'display nil))
> (setq beg next))))
This looks unorthodox but OK, I don't have a snappy answer
what to do instead...
> (defun tex-typeface-crucible ()
> "Font-lock setup for mathematical symbols."
> (font-lock-flush (point-min) (point-max))
Is that the same as just (font-lock-flush) ?
> (if crucible-supinf-enable
> (progn
> (font-lock-add-keywords nil crucible-tex-keywords t)
> (font-lock-add-keywords nil supinf-font-lock-cruc t))
> (font-lock-remove-keywords nil crucible-tex-keywords)
> (supinf-disable-cruc (point-min) (point-max)))
> (font-lock-flush (point-min) (point-max)))
Is that the same as ... same.
--
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal
next prev parent reply other threads:[~2021-02-08 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 15:02 Separating colour and positioning functioning Christopher Dimech
2021-02-08 21:37 ` Emanuel Berg via Users list for the GNU Emacs text editor [this message]
2021-02-09 0:20 ` Christopher Dimech
2021-02-09 0:27 ` Christopher Dimech
2021-02-09 1:01 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-02-09 2:30 ` Christopher Dimech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s7yp7fh.fsf@zoho.eu \
--to=help-gnu-emacs@gnu.org \
--cc=moasenwood@zoho.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).