From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.help Subject: Re: how to track down "invalid face attribute" errors? Date: Wed, 05 Oct 2022 15:31:49 +0200 Message-ID: <877d1e8khm.fsf@gmail.com> References: <87k05rr79k.fsf@ucl.ac.uk> <87czbjpq1c.fsf@dataswamp.org> <87v8pawlpy.fsf@ucl.ac.uk> <87sfkea2yw.fsf@gmail.com> <87r0zxm5pv.fsf@sperrhaken.name> <87ill89ag4.fsf@gmail.com> <87a66acuyj.fsf@sperrhaken.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24338"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: Felix Dietrich Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 05 16:02:11 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1og4yR-0006AW-OH for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 16:02:11 +0200 Original-Received: from localhost ([::1]:46482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og4yQ-0003Ki-OZ for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 10:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og4V9-00061P-Ca for help-gnu-emacs@gnu.org; Wed, 05 Oct 2022 09:31:55 -0400 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:42724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1og4V7-0005W7-Od for help-gnu-emacs@gnu.org; Wed, 05 Oct 2022 09:31:55 -0400 Original-Received: by mail-wm1-x32c.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so1025924wmq.1 for ; Wed, 05 Oct 2022 06:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=htb5tXextyAMTy4TPQFaLhdaOnGem/ERzl9OSA2bvtI=; b=Bct1a4A/DuZxQPZ1VVFBNLv79IWcSZZsjUR1GzzFSYAamFwcaIf9JjP+UO1KC379f2 jsIZybv6IvNEYUJZMulltU8OrJ8ASdluLkXB3CrqTST+mDvMVzBKOJsxh4E5BioP5lU4 9fn7PGVGz7XNrUTu54iGcLe0qfw3RJeRuQEcytmF8vASIDqN2sEUwgpCRL91gRWBQp86 2vLVSzkyNq59Hqxkx2Jys5JDisO6UuTENOQsks5Lwc15o2Rq2lAZ2OJYHOMi0qHT+xWG 6VRgZB8rV6iEfU8SlWMjjBrjny6OQpNWz6V/9UhY47ewU0ZLsvpWa5RX/Sf++IHC2gAd UBzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=htb5tXextyAMTy4TPQFaLhdaOnGem/ERzl9OSA2bvtI=; b=bO3zocYP24hQa8gdftmfuneAFZXmk6x8hAvJhazEwUq6Llk1rH14hVIQlqaMHgyyew E3T8Pjod8cgec7D75Q72CdzGLm7LyqQGAAzGZU95D4D102oEAoTpvWRjUFpY8lDDdo1b zrYpa8t/2kIj42PL1OsLMjkpVr+4SK7hr+5BxvG3ikxPNMu5IOIEId26w57a4YJeDzE7 MtzLxI7AtzinCEl1xpNGsXstL0emZqzy588z3m7WW15jZTKMEHI1tMvqqHYkRhC67lJr misW+Ii9F/45R8ErOMmxOl3lPDoqHs1/ceMmmzlGBuaQI3V3zRf0wV+wPVn0AdlAmLJX kAIg== X-Gm-Message-State: ACrzQf1cQ0ctiIGoG2ctjpZ8aTeBLEmwbKGHH+jCfbKq4qj+aMD5JpOw SwzM5z1zBMkXqIn5x+k7KS3dSUCJg5Y= X-Google-Smtp-Source: AMsMyM7kI85BK0cKCYlo3O241yjNRi/sv1pCTvecsbxsu6SSSr0+f6tRHOk9chmq210JM4jX6uRuQw== X-Received: by 2002:a05:600c:3b13:b0:3b4:757d:93a5 with SMTP id m19-20020a05600c3b1300b003b4757d93a5mr3331686wms.183.1664976711449; Wed, 05 Oct 2022 06:31:51 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:37a5:6c3e:78d8:b7fc]) by smtp.gmail.com with ESMTPSA id r68-20020a1c2b47000000b003b47ff307e1sm1904129wmr.31.2022.10.05.06.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 06:31:50 -0700 (PDT) In-Reply-To: <87a66acuyj.fsf@sperrhaken.name> (Felix Dietrich's message of "Wed, 05 Oct 2022 14:32:04 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:139719 Archived-At: >>>>> On Wed, 05 Oct 2022 14:32:04 +0200, Felix Dietrich said: Felix> But =E2=80=9Cxfaces.c:merge_face_ref=E2=80=9D (which produces th= e error message) has a Felix> =E2=80=9Cstruct window w=E2=80=9D parameter. I believe in cases= where it is not NULL, Felix> which it isn=CA=BCt when running the above code, this could be u= sed to derive Felix> the buffer and the buffer=CA=BCs position using the struct membe= rs =E2=80=9Ccontents=E2=80=9D Felix> and =E2=80=9Cpointm=E2=80=99: 1. =E2=80=9Ccontents=E2=80=9D stor= es, for leaf windows, the windows Felix> buffer; its descriptions mentions other possible value types it = may hold Felix> [1]; I do not know in how far these other types have to be consi= dered Felix> here. 2. =E2=80=9Cpointm=E2=80=9D refers to a marker holding th= e current buffer Felix> position in window; its description states that it is =E2=80=9Cu= sed only when Felix> the window is not selected=E2=80=9D. Therefore, it is possible = that, if the Felix> window =E2=80=9Cw=E2=80=9D is the selected one, the point would = have to be taken from Felix> another source (perhaps the =E2=80=9CPT=E2=80=9D macro in =E2=80= =9Cbuffer.h=E2=80=9D). We=CA=BCre not necessarily examining the faces of the character at (point), we=CA=BCre going through redisplay of the buffer, I thought? Felix> Also note that, if the position would be added to the log entry, Felix> multiple log entries would not be merged anymore. Additionally,= with Felix> the code above, the position is actually after the text (at Felix> =E2=80=98point-max=E2=80=99); therefore, this might not be usefu= l information to add. Felix> I am not sure if the whole thing is worth the effort or would co= mplicate Felix> the creation of a simple log entry for a, hopefully, rare case t= o much. It=CA=BCs more effort than I=CA=BCm willing to go to, at least :-) Felix> Anyway, perhaps, if there is any interest in adding information = to the Felix> =E2=80=9CInvalid face attribute=E2=80=9D log message, further di= scussion should move to Felix> a wishlist bug report? Yes. That will get it in front of people who know the relevant code better than I do. Robert --=20