From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.help Subject: Re: package-vc-install fails to build docs Date: Sun, 23 Apr 2023 12:37:38 +0000 Message-ID: <877cu293l9.fsf@posteo.net> References: <87a5z0sc3r.fsf@breatheoutbreathe.in> <871qkcl6kq.fsf@posteo.net> <877cu3o6ld.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26090"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org, Ruijie Yu To: Joseph Turner Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 23 14:37:49 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqYyS-0006dS-P3 for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 23 Apr 2023 14:37:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqYxv-0005XZ-9t; Sun, 23 Apr 2023 08:37:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqYxq-0005XM-Gr for help-gnu-emacs@gnu.org; Sun, 23 Apr 2023 08:37:11 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqYxo-00048u-FP for help-gnu-emacs@gnu.org; Sun, 23 Apr 2023 08:37:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3F87F24009B for ; Sun, 23 Apr 2023 14:37:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682253427; bh=NK7EHTgHSyF8c6d92ulMC/nAXL2AioH7xddmNcoBtCg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=pYfpiMcpBEZIIU9d7wffTEsJ1tDKn9/tWcJlcsbWnrjVCTxH/YRgcMZ9MT7qHhBlg nSfOgheLCNJM6y6tNNVfnBeFf0cAaxIqhPMdokJdNQc0vksZKeRxZdo/mEDZqdIcjM A6xEdU6PVJJop+5nQBYHTLqc/DtfwPKRPaeXVOb9XUx4BkQSlflcH6j1uStSizlZy4 FeTYxnaT1o9/aduSifLtv0PcuIAkp7J1PswLWuHlZNftxBB9NLbjqdYhWicOLuA/y/ qfZZiAPjYRTp8OQXKh3xaVnaAvqysgq8Neb/pTVI4kZJAAawlr0efW1YjGS8E6vp/8 0kmLDYqBsNoag== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q477Q5LDFz9rxM; Sun, 23 Apr 2023 14:37:06 +0200 (CEST) In-Reply-To: <877cu3o6ld.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 22 Apr 2023 15:56:09 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:143342 Archived-At: Joseph Turner writes: > Thank you Ruijie Yu and Philip Kaludercic for your help! > > Philip Kaludercic writes: > >> Ruijie Yu via Users list for the GNU Emacs text editor >> writes: >>> I'm looking at the package-vc source code, and it doesn't seem to try to >>> autodetect any doc files at the moment. Try adding `:doc` in your >>> `package-vc-install' call and see if anything changes. > > Actually, it looks like extra plist elements like :doc are stripped away > in package-vc--unpack. package-vc--unpack doesn't pass its pkg-spec arg > along to package-vc--unpack-1. package-vc--unpack-1 then calls > package-vc--desc->spec, which gets the spec anew from ELPA IIUC. > > Regardless, I believe the issue lies elsewhere, see below. > >> Right, if you just pass a URL, then package-vc has no metadata. But >> since org-transclusion is on ELPA, you can invoke it like this: >> >> (package-vc-install 'org-transclusion) >> >> then it should re-use the package specification that GNU ELPA provides. >> If you invoke package-vc-install interactively, it would also prompt you >> with this package name. >> >> That being said, I just tried it out and it seems that it still doesn't >> work because of a discrepancy between the package specification on ELPA >> that mentions docs/org-transclusion.org to be the documentation file >> >> (org-transclusion :url "https://github.com/nobiot/org-transclusion" >> :make "org-transclusion.org" >> :doc "docs/org-transclusion.org" >> :readme "README.org") >> >> and as you say the fact that the actual manual lies in >> docs/org-transclusion-manual.org. But this is an issue that should >> either be fixed in ELPA if the maintainer wishes this file to be used, >> or upstream if this is a mistake. > > nobiot (org-transclusion author) points out here > https://github.com/nobiot/org-transclusion/issues/182#issuecomment-1518676316 > that docs/org-transclusion.org needs to be generated from > docs/org-transclusion-manual.org according to > > :make "org-transclusion.org" > > (search for ":make" in > https://git.savannah.gnu.org/cgit/emacs/elpa.git/plain/README ) > > It appears that package-vc hasn't been taught to make use of the :make > package spec key. A quick search inside of > https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/elpa-packages#n491 > reveals only two other packages besides org-transclusion that use it. You are right (and I totally missed the :make entry in the specification above). Package-vc did intentionally NOT add :make or :shell-command support, for the sake of user safety. It wouldn't be difficult to implement this, if we could find a way to make it reasonably safe (e.g. if the user has to opt-in or we trust package specifications if they were delivered by a trusted package archive). >>> I'm on recent master, what is your Emacs version? > > GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, > cairo version 1.16.0) > > In conclusion, I think the issue is that package-vc doesn't yet support > the package spec :make key. > > Cheers, > > Joseph