Re: wrong type error in local variables

Re: wrong type error in local variables

[Anders Munch]

Emanuel Berg:
>> Okay, but what exactly is the problem with it, from Lisp?
Douglas Lewan:
> The problem is that it changes the buffer.

Which is sometimes what you want.
I grepped my personal elisp for find-file, and found three uses, neither of which
could be replaced by find-file-noselect.

regards,
Anders

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Anders Munch wrote:

>>> Okay, but what exactly is the problem with it,
>>>
>> from Lisp?
>> The problem is that it changes the buffer.
>
> Which is sometimes what you want. I grepped my
> personal elisp for find-file, and found three uses,
> neither of which could be replaced by
> find-file-noselect.

Okay? Do tell?

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Douglas Lewan]

On 7/3/20 4:33 AM, Anders Munch wrote:
> Douglas Lewan:
>> The problem is that it changes the buffer.
> Which is sometimes what you want.
> I grepped my personal elisp for find-file, and found three uses, neither of which
> could be replaced by find-file-noselect.
>
> regards,
> Anders
I agree. /Sometimes/ it's what you want. I know I've written things that 
use dired-find-file, but that's usually the last thing I call. The 
underlying application doesn't depend on switching to another buffer; 
it's just that the result switches the buffer at the end just for the 
user. /Usually/ an application doesn't want to do that. After all, 
switching buffers more than once might undo a previous switch.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

wrong type error in local variables

[Douglas Lewan]

I have a TeX file with the following local variables:

     Local Variables:
     eval: (ab-new-buffer (prog1 (find-file "chapter16.tex") (message "After find file.")))
     End:

The (find-file) succeeds. (There's a buffer with that file and I see the 
message.) However, overall I get this error:

     File local-variables error: (wrong-type-argument stringp nil)

I assume the call to (ab-new-buffer) gets the error, but as far as I can 
tell that call never happens. (ab-new-buffer) has the following definition:

     (defun ab-new-buffer (buffer-or-name)
       (error "Now in (ab-new-buffer)."))

I never see that error.
What am I missing?

FYI The data above are obviously reduced to a minimal case. With the 
correct definition of (ab-new-buffer) a full battery of tests passes.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Joost Kremers]

On Thu, Jul 02 2020, Douglas Lewan wrote:
> I have a TeX file with the following local variables:
>
>      Local Variables:
>      eval: (ab-new-buffer (prog1 (find-file "chapter16.tex") 
>      (message "After find file.")))
>      End:
>
> The (find-file) succeeds. (There's a buffer with that file and I 
> see the 
> message.) However, overall I get this error:
>
>      File local-variables error: (wrong-type-argument stringp 
>      nil)
>
> I assume the call to (ab-new-buffer) gets the error, but as far 
> as I can 
> tell that call never happens. (ab-new-buffer) has the following 
> definition:
>
>      (defun ab-new-buffer (buffer-or-name)
>        (error "Now in (ab-new-buffer)."))
>
> I never see that error.
> What am I missing?
>
> FYI The data above are obviously reduced to a minimal case. With 
> the 
> correct definition of (ab-new-buffer) a full battery of tests 
> passes.

Seems to work fine for me. Are you sure you have nothing else in 
your local variables block? And what about the local variables 
block of the file you're finding in your local variables block 
(i.e., "chapter16.tex")?

Try setting `debug-on-error` (do `M-x toggle-debug-on-error`) and 
then open the file. You should then get a backtrace that may 
provide more information. If you don't know what to make of it, 
post it here.

HTH

-- 
Joost Kremers
Life has its moments

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 11:06 AM, Joost Kremers wrote:
>
> On Thu, Jul 02 2020, Douglas Lewan wrote:
>> I have a TeX file with the following local variables:
>>
>>      Local Variables:
>>      eval: (ab-new-buffer (prog1 (find-file "chapter16.tex")      
>> (message "After find file.")))
>>      End:
>>
>> The (find-file) succeeds. (There's a buffer with that file and I see 
>> the message.) However, overall I get this error:
>>
>>      File local-variables error: (wrong-type-argument stringp      nil)
>>
>> I assume the call to (ab-new-buffer) gets the error, but as far as I 
>> can tell that call never happens. (ab-new-buffer) has the following 
>> definition:
>>
>>      (defun ab-new-buffer (buffer-or-name)
>>        (error "Now in (ab-new-buffer)."))
>>
>> I never see that error.
>> What am I missing?
>>
>> FYI The data above are obviously reduced to a minimal case. With the 
>> correct definition of (ab-new-buffer) a full battery of tests passes.
>
> Seems to work fine for me. Are you sure you have nothing else in your 
> local variables block? And what about the local variables block of the 
> file you're finding in your local variables block (i.e., 
> "chapter16.tex")?

I do have other things in the local variables, but that suggestion 
prompted me to try this in emacs -Q where I do see the above error.  
I'll try again in a clean emacs.

Now I have to wonder just how dirty I've made emacs....

Thanks for the prompt.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Stefan Monnier]

>     Local Variables:
>     eval: (ab-new-buffer (prog1 (find-file "chapter16.tex") (message "After find file.")))
>     End:

Joost Kremers gave a good answer.  I'll just add some "unrelated" comments:

- `find-file` should not be called from Elisp.
  Use `find-file-noselect` instead.

- It's OK to temporarily change to another buffer, but your "eval"
  should eventually return to the original buffer.  Otherwise, do expect
  weird behaviors.  IOW wrap a `save/with-current-buffer` around your code.


        Stefan

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Stefan Monnier wrote:

> `find-file` should not be called from Elisp.
> Use `find-file-noselect` instead.

Oups, if so I have 15 changes to make.

Why doesn't the byte compiler say this?

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 12:36 PM, Emanuel Berg via Users list for the GNU Emacs text 
editor wrote:
> Stefan Monnier wrote:
>
>> `find-file` should not be called from Elisp.
>> Use `find-file-noselect` instead.
> Oups, if so I have 15 changes to make.
>
> Why doesn't the byte compiler say this?
Or even the docstring? Lots of docstrings mention such things.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Douglas Lewan wrote:

>>> `find-file` should not be called from Elisp.
>>> Use `find-file-noselect` instead.
>>
>> Oups, if so I have 15 changes to make.
>>
>> Why doesn't the byte compiler say this?
>
> Or even the docstring? Lots of docstrings mention
> such things.

... and the more the better!

Well, the ideal would be that everything could be
used from everywhere.

Put a `cond' in `find-file' and branch to
`find-file-noselect' if called from Lisp :)

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Stefan Monnier]

>> `find-file` should not be called from Elisp.
>> Use `find-file-noselect` instead.
> Oups, if so I have 15 changes to make.
> Why doesn't the byte compiler say this?

Because noone has added the annotation for it yet (tho there are
various comments in the code that say so).

FWIW, I just tried adding it (see patch below), and I see that we have
many cases in Emacs's own Lisp code where we call `find-file`
from Elisp.  I suspect that many of them would benefit from being
changed, but the need to go and update all those cases might be a
reason why it hasn't been done yet :-(


        Stefan


diff --git a/lisp/files.el b/lisp/files.el
index 742fd78df1d..a29d02bf591 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -1688,6 +1688,7 @@ find-file
 
 To visit a file without any kind of conversion and without
 automatically choosing a major mode, use \\[find-file-literally]."
+  (declare (interactive-only find-file-noselect))
   (interactive
    (find-file-read-args "Find file: "
                         (confirm-nonexistent-file-or-buffer)))
@@ -1761,15 +1762,16 @@ find-file-other-frame
       (switch-to-buffer-other-frame value))))
 
 (defun find-file-existing (filename)
-   "Edit the existing file FILENAME.
+  "Edit the existing file FILENAME.
 Like \\[find-file], but allow only a file that exists, and do not allow
 file names with wildcards."
-   (interactive (nbutlast (find-file-read-args "Find existing file: " t)))
-   (if (and (not (called-interactively-p 'interactive))
-	    (not (file-exists-p filename)))
-       (error "%s does not exist" filename)
-     (find-file filename)
-     (current-buffer)))
+  (interactive (nbutlast (find-file-read-args "Find existing file: " t)))
+  (if (not (or (called-interactively-p 'interactive)
+               (file-exists-p filename)))
+      (error "%s does not exist" filename)
+    (with-suppressed-warnings ((interactive-only find-file))
+      (find-file filename))
+    (current-buffer)))
 
 (defun find-file--read-only (fun filename wildcards)
   (unless (or (and wildcards find-file-wildcards

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Stefan Monnier wrote:

>>> `find-file` should not be called from Elisp.
>>> Use `find-file-noselect` instead.
>>
>> Oups, if so I have 15 changes to make. Why doesn't
>> the byte compiler say this?
>
> Because noone has added the annotation for it yet
> (tho there are various comments in the code that
> say so).

Okay, but what exactly is the problem with it,
from Lisp?

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 9:19 PM, Emanuel Berg via Users list for the GNU Emacs text 
editor wrote:
> Stefan Monnier wrote:
>
>>>> `find-file` should not be called from Elisp.
>>>> Use `find-file-noselect` instead.
>>> Oups, if so I have 15 changes to make. Why doesn't
>>> the byte compiler say this?
>> Because noone has added the annotation for it yet
>> (tho there are various comments in the code that
>> say so).
> Okay, but what exactly is the problem with it,
> from Lisp?
>
The problem is that it changes the buffer.

If a (find-file) fails and you were depending on the change of the 
current buffer all kinds of other things might go wrong.

If you use (find-file-noselect), then the current buffer doesn't change 
and any attempt to use that buffer would fail. In particular, you should 
be verifying that the (find-file-noselect) succeeded.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Douglas Lewan wrote:

>> Okay, but what exactly is the problem with it,
>> from Lisp?
>
> The problem is that it changes the buffer.
>
> If a (find-file) fails and you were depending on
> the change of the current buffer all kinds of other
> things might go wrong.
>
> If you use (find-file-noselect), then the current
> buffer doesn't change and any attempt to use that
> buffer would fail. In particular, you should be
> verifying that the (find-file-noselect) succeeded.

Gotcha, but then why not just have a single such
function that does the checking itself and aborts
further execution immediately after the initial,
failed attempt to find the file? Then 1 (onee)
function would be used, and with no need to
explicitely check if it succeeded?

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 10:00 PM, Emanuel Berg via Users list for the GNU Emacs text 
editor wrote:
> Douglas Lewan wrote:
>
>>> Okay, but what exactly is the problem with it,
>>> from Lisp?
>> The problem is that it changes the buffer.
>>
>> If a (find-file) fails and you were depending on
>> the change of the current buffer all kinds of other
>> things might go wrong.
>>
>> If you use (find-file-noselect), then the current
>> buffer doesn't change and any attempt to use that
>> buffer would fail. In particular, you should be
>> verifying that the (find-file-noselect) succeeded.
> Gotcha, but then why not just have a single such
> function that does the checking itself and aborts
> further execution immediately after the initial,
> failed attempt to find the file? Then 1 (onee)
> function would be used, and with no need to
> explicitely check if it succeeded?

I understand. Such a solution has already been proposed here. I'm just 
responding to the world we currently live in. And, yes, encapsulation of 
such issues is a reasonable thing.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Douglas Lewan wrote:

> you should be verifying that the
> (find-file-noselect) succeeded.

BTW, how do you verify that?

  (when (find-file-noselect "~/.emacs") t) ; t

but also

  (when (find-file-noselect "~/there-is-no-file") t) ; t


-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 11:45 PM, Emanuel Berg via Users list for the GNU Emacs text 
editor wrote:
> Douglas Lewan wrote:
>
>> you should be verifying that the
>> (find-file-noselect) succeeded.
> BTW, how do you verify that?
>
>    (when (find-file-noselect "~/.emacs") t) ; t
>
> but also
>
>    (when (find-file-noselect "~/there-is-no-file") t) ; t
Good question. Maybe it can't fail. I've certainly worked in other 
worlds where such cases exist. I imagine that (find-file-noselect nil) 
would not behave well, but in that situation you probably should have 
caught the nil first.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Emanuel Berg via Users list for the GNU Emacs text editor]

Douglas Lewan wrote:

>>> you should be verifying that the
>>> (find-file-noselect) succeeded.
>>
>> BTW, how do you verify that?
>>
>>    (when (find-file-noselect "~/.emacs") t) ; t
>>
>> but also
>>
>>    (when (find-file-noselect "~/there-is-no-file") t) ; t
>
> Good question. Maybe it can't fail. I've certainly
> worked in other worlds where such cases exist.
> I imagine that (find-file-noselect nil) would not
> behave well

find-file-noselect: Wrong type argument: stringp, nil

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 11:56 AM, Stefan Monnier wrote:
> Joost Kremers gave a good answer.  I'll just add some "unrelated" comments:
>
> - `find-file` should not be called from Elisp.
>    Use `find-file-noselect` instead.
>
> - It's OK to temporarily change to another buffer, but your "eval"
>    should eventually return to the original buffer.  Otherwise, do expect
>    weird behaviors.  IOW wrap a `save/with-current-buffer` around your code.
>
>
>          Stefan
Done. Thanks.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.

Re: wrong type error in local variables

[Douglas Lewan]

On 7/2/20 11:56 AM, Stefan Monnier wrote:
> - It's OK to temporarily change to another buffer, but your "eval"
>    should eventually return to the original buffer.  Otherwise, do expect
>    weird behaviors.  IOW wrap a `save/with-current-buffer` around your code.

That was it. Changing the buffer messed up a dependency on the book.tex 
buffer.

Thanks.

-- 
,Doug
d.lewan2000@gmail.com
(908) 720 7908

If this is what winning looks like, I'd hate to see what losing is.