From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: help-gnu-emacs@gnu.org
Subject: Re: proper use of add-function
Date: Wed, 23 May 2018 01:58:23 +0200 [thread overview]
Message-ID: <874lizgs4g.fsf@web.de> (raw)
In-Reply-To: <87603fxnxi.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 22 May 2018 16:36:57 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Okay, I see what you and Noam are saying, and in fact what the docstring
> is saying. It's just pretty weird that `add-function' works on
> variables, and `advice-add' works on functions.
Actually `add-function' works for "places" (including
`symbol-function'), so it's the more general and more low-level tool.
`advice-add' is higher-level and specialized on function names.
> It's counterintuitive, and I wonder if the docs couldn't make that
> more explicit.
I always found the doc ok (and explicit), but maybe the names are a bit
arbitrary.
Michael.
next prev parent reply other threads:[~2018-05-22 23:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 22:58 proper use of add-function Eric Abrahamsen
2018-05-22 23:18 ` Noam Postavsky
2018-05-22 23:31 ` Michael Heerdegen
2018-05-22 23:36 ` Eric Abrahamsen
2018-05-22 23:58 ` Michael Heerdegen [this message]
2018-05-23 0:09 ` Eric Abrahamsen
2018-05-23 0:19 ` Noam Postavsky
2018-05-23 0:29 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lizgs4g.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=eric@ericabrahamsen.net \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).