unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Defining minor mode with minor-mode condition
Date: Tue, 04 May 2021 15:01:31 +0200	[thread overview]
Message-ID: <874kfihcus.fsf@zoho.eu> (raw)
In-Reply-To: jwvv97yoeaw.fsf-monnier+emacs@gnu.org

Stefan Monnier wrote:

> I actually often find it convenient to unconditionally
> "disable" first:
>
>     (define-minor-mode crucibulum-minor-mode
>       "Minor mode for assisting with superior & inferior typeface."
>       :lighter " Crucibulum"
>       (disable-texcom-typeface)
>       (disable-ricci-notation)
>       (when crucibulum-minor-mode
>         (enable-texcom-typeface)
>         (enable-ricci-notation)))
>
> the advantage is to avoid problems where, say,
> `enable-texcom-typeface` is not idempotent, so if you call
> (crucibulum-minor-mode 1) several times you might end up
> with multiple copies of the same thing added to a list.

Good!

What about one function to enable all and one to disable all?

No - then these functions can be called from the outside which
will/can add confusion, and worse, enable some of the minor
mode functionality but not actually enabling the minor
mode itself!

-- 
underground experts united
https://dataswamp.org/~incal




  reply	other threads:[~2021-05-04 13:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  3:52 Defining minor mode with minor-mode condition Christopher Dimech
2021-05-04  4:12 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-04  7:01 ` Joost Kremers
2021-05-04  7:20   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-04 12:52   ` Stefan Monnier
2021-05-04 13:01     ` Emanuel Berg via Users list for the GNU Emacs text editor [this message]
2021-05-04 13:03     ` Christopher Dimech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kfihcus.fsf@zoho.eu \
    --to=help-gnu-emacs@gnu.org \
    --cc=moasenwood@zoho.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).